Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed h_neglect args from remapping_core_h() #13

Open
wants to merge 1 commit into
base: non_opt_h_neglect
Choose a base branch
from
Open

Removed h_neglect args from remapping_core_h() #13

wants to merge 1 commit into from

Commits on Aug 3, 2024

  1. Removed h_neglect args from remapping_core_h() 

    The API for remaping_core_h() should not have h_neglect as an argument,
so converting it from optional to mandatory has moved things in the wrong
direction. The better way to get the *truly optional* parameter into the
remapping is as a parameter in the type. This commit implements that for
the remapping type. In the "big" refactor, the parameters are further moved
down to be associated with the actual reconstruction schemes.
    @adcroft
    adcroft committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    14c977c View commit details
    Browse the repository at this point in the history