Add enableLoggingFail option for failed introspect to FixtureMonkeyOp…

…tions (naver#1066)
HanJaehee · Oct 24, 2024 · 35637b7 · 35637b7
1 parent f5dbfa0
commit 35637b7
Show file tree

Hide file tree

Showing 10 changed files with 50 additions and 15 deletions.
diff --git a/...pi/src/main/java/com/navercorp/fixturemonkey/api/generator/ArbitraryGeneratorContext.java b/...pi/src/main/java/com/navercorp/fixturemonkey/api/generator/ArbitraryGeneratorContext.java
@@ -60,6 +60,7 @@ public final class ArbitraryGeneratorContext implements Traceable {
 	private final int generateUniqueMaxTries;
 	private final AtomicReference<CombinableArbitrary<?>> generated =
 		new AtomicReference<>(CombinableArbitrary.NOT_GENERATED);
+	private final boolean enableLoggingFail;
 
 	public ArbitraryGeneratorContext(
 		Property resolvedProperty,
@@ -69,7 +70,8 @@ public ArbitraryGeneratorContext(
 		BiFunction<ArbitraryGeneratorContext, ArbitraryProperty, CombinableArbitrary<?>> resolveArbitrary,
 		LazyArbitrary<PropertyPath> lazyPropertyPath,
 		MonkeyGeneratorContext monkeyGeneratorContext,
-		int generateUniqueMaxTries
+		int generateUniqueMaxTries,
+		boolean enableLoggingFail
 	) {
 		this.resolvedProperty = resolvedProperty;
 		this.property = property;
@@ -79,6 +81,7 @@ public ArbitraryGeneratorContext(
 		this.lazyPropertyPath = lazyPropertyPath;
 		this.monkeyGeneratorContext = monkeyGeneratorContext;
 		this.generateUniqueMaxTries = generateUniqueMaxTries;
+		this.enableLoggingFail = enableLoggingFail;
 	}
 
 	public ArbitraryProperty getArbitraryProperty() {
@@ -149,6 +152,10 @@ public int getGenerateUniqueMaxTries() {
 		return generateUniqueMaxTries;
 	}
 
+	public boolean isEnableLoggingFail() {
+		return enableLoggingFail;
+	}
+
 	public CombinableArbitrary<?> getGenerated() {
 		return generated.get();
 	}

diff --git a/...src/main/java/com/navercorp/fixturemonkey/api/introspector/BeanArbitraryIntrospector.java b/...src/main/java/com/navercorp/fixturemonkey/api/introspector/BeanArbitraryIntrospector.java
@@ -66,7 +66,9 @@ public ArbitraryIntrospectorResult introspect(ArbitraryGeneratorContext context)
 			try {
 				checkPrerequisite(type);
 			} catch (Exception ex) {
-				LOGGER.warn("Given type {} is failed to generate due to the exception. It may be null.", type, ex);
+				if (context.isEnableLoggingFail()) {
+					LOGGER.warn("Given type {} is failed to generate due to the exception. It may be null.", type, ex);
+				}
 				return ArbitraryIntrospectorResult.NOT_INTROSPECTED;
 			}
 			generated = CombinableArbitrary.from(() -> Reflections.newInstance(type));

diff --git a/.../main/java/com/navercorp/fixturemonkey/api/introspector/BuilderArbitraryIntrospector.java b/.../main/java/com/navercorp/fixturemonkey/api/introspector/BuilderArbitraryIntrospector.java
@@ -90,7 +90,9 @@ public ArbitraryIntrospectorResult introspect(ArbitraryGeneratorContext context)
 				}
 			);
 		} catch (Exception ex) {
-			LOGGER.warn("Given type {} is failed to generate due to the exception. It may be null.", type, ex);
+			if (context.isEnableLoggingFail()) {
+				LOGGER.warn("Given type {} is failed to generate due to the exception. It may be null.", type, ex);
+			}
 			return ArbitraryIntrospectorResult.NOT_INTROSPECTED;
 		}
 		Method builderMethod = BUILDER_CACHE.get(type);

diff --git a/.../navercorp/fixturemonkey/api/introspector/ConstructorPropertiesArbitraryIntrospector.java b/.../navercorp/fixturemonkey/api/introspector/ConstructorPropertiesArbitraryIntrospector.java
@@ -68,11 +68,13 @@ public ArbitraryIntrospectorResult introspect(ArbitraryGeneratorContext context)
 
 		Entry<Constructor<?>, String[]> parameterNamesByConstructor = TypeCache.getParameterNamesByConstructor(type);
 		if (parameterNamesByConstructor == null) {
-			LOGGER.warn(
-				"Given type {} is failed to generate due to the exception. It may be null.",
-				type,
-				new IllegalArgumentException("Primary Constructor does not exist. type " + type.getSimpleName())
-			);
+			if (context.isEnableLoggingFail()) {
+				LOGGER.warn(
+					"Given type {} is failed to generate due to the exception. It may be null.",
+					type,
+					new IllegalArgumentException("Primary Constructor does not exist. type " + type.getSimpleName())
+				);
+			}
 			return ArbitraryIntrospectorResult.NOT_INTROSPECTED;
 		}
 

diff --git a/...-api/src/main/java/com/navercorp/fixturemonkey/api/introspector/FailoverIntrospector.java b/...-api/src/main/java/com/navercorp/fixturemonkey/api/introspector/FailoverIntrospector.java
@@ -57,7 +57,7 @@ public ArbitraryIntrospectorResult introspect(ArbitraryGeneratorContext context)
 					results.add(new FailoverIntrospectorResult(introspector, result));
 				}
 			} catch (Exception ex) {
-				if (enableLoggingFail) {
+				if (context.isEnableLoggingFail() || enableLoggingFail) {
 					LOGGER.warn(
 						String.format(
 							"\"%s\" is failed to introspect \"%s\" type.",
@@ -85,7 +85,7 @@ public Object combined() {
 							result = iterator.next();
 							return result.getResult().getValue().combined();
 						} catch (Exception ex) {
-							if (enableLoggingFail) {
+							if (context.isEnableLoggingFail() || enableLoggingFail) {
 								LOGGER.warn(
 									String.format(
 										"\"%s\" is failed to introspect \"%s\" type.",
@@ -115,7 +115,7 @@ public Object rawValue() {
 							result = iterator.next();
 							return result.getResult().getValue().rawValue();
 						} catch (Exception ex) {
-							if (enableLoggingFail) {
+							if (context.isEnableLoggingFail() || enableLoggingFail) {
 								LOGGER.warn(
 									String.format(
 										"\"%s\" is failed to introspect type \"%s\"",

diff --git a/...va/com/navercorp/fixturemonkey/api/introspector/FieldReflectionArbitraryIntrospector.java b/...va/com/navercorp/fixturemonkey/api/introspector/FieldReflectionArbitraryIntrospector.java
@@ -62,7 +62,9 @@ public ArbitraryIntrospectorResult introspect(ArbitraryGeneratorContext context)
 			try {
 				checkPrerequisite(type);
 			} catch (Exception ex) {
-				LOGGER.warn("Given type {} is failed to generate due to the exception. It may be null.", type, ex);
+				if (context.isEnableLoggingFail()) {
+					LOGGER.warn("Given type {} is failed to generate due to the exception. It may be null.", type, ex);
+				}
 				return ArbitraryIntrospectorResult.NOT_INTROSPECTED;
 			}
 			generated = CombinableArbitrary.from(() -> Reflections.newInstance(type));

diff --git a/...monkey-api/src/main/java/com/navercorp/fixturemonkey/api/option/FixtureMonkeyOptions.java b/...monkey-api/src/main/java/com/navercorp/fixturemonkey/api/option/FixtureMonkeyOptions.java
@@ -169,6 +169,7 @@ public final class FixtureMonkeyOptions {
 	private final JavaConstraintGenerator javaConstraintGenerator;
 	private final InstantiatorProcessor instantiatorProcessor;
 	private final List<MatcherOperator<CandidateConcretePropertyResolver>> candidateConcretePropertyResolvers;
+	private final boolean enableLoggingFail;
 
 	public FixtureMonkeyOptions(
 		List<MatcherOperator<PropertyGenerator>> propertyGenerators,
@@ -189,7 +190,8 @@ public FixtureMonkeyOptions(
 		int generateUniqueMaxTries,
 		JavaConstraintGenerator javaConstraintGenerator,
 		InstantiatorProcessor instantiatorProcessor,
-		List<MatcherOperator<CandidateConcretePropertyResolver>> candidateConcretePropertyResolvers
+		List<MatcherOperator<CandidateConcretePropertyResolver>> candidateConcretePropertyResolvers,
+		boolean enableLoggingFail
 	) {
 		this.propertyGenerators = propertyGenerators;
 		this.defaultPropertyGenerator = defaultPropertyGenerator;
@@ -210,6 +212,7 @@ public FixtureMonkeyOptions(
 		this.javaConstraintGenerator = javaConstraintGenerator;
 		this.instantiatorProcessor = instantiatorProcessor;
 		this.candidateConcretePropertyResolvers = candidateConcretePropertyResolvers;
+		this.enableLoggingFail = enableLoggingFail;
 	}
 
 	public static FixtureMonkeyOptionsBuilder builder() {
@@ -351,6 +354,10 @@ public InstantiatorProcessor getInstantiatorProcessor() {
 		return instantiatorProcessor;
 	}
 
+	public boolean isEnableLoggingFail() {
+		return enableLoggingFail;
+	}
+
 	@Nullable
 	public CandidateConcretePropertyResolver getCandidateConcretePropertyResolver(Property property) {
 		List<CandidateConcretePropertyResolver> candidateConcretePropertyResolverList =

diff --git a/...api/src/main/java/com/navercorp/fixturemonkey/api/option/FixtureMonkeyOptionsBuilder.java b/...api/src/main/java/com/navercorp/fixturemonkey/api/option/FixtureMonkeyOptionsBuilder.java
@@ -108,6 +108,7 @@ public final class FixtureMonkeyOptionsBuilder {
 	private boolean defaultNotNull = false;
 	private boolean nullableContainer = false;
 	private boolean nullableElement = false;
+	private boolean enableLoggingFail = true;
 	private UnaryOperator<NullInjectGenerator> defaultNullInjectGeneratorOperator = it -> it;
 	private ArbitraryValidator defaultArbitraryValidator = (obj) -> {
 	};
@@ -453,6 +454,11 @@ public FixtureMonkeyOptionsBuilder nullableElement(boolean nullableElement) {
 		return this;
 	}
 
+	public FixtureMonkeyOptionsBuilder enableLoggingFail(boolean enableLoggingFail) {
+		this.enableLoggingFail = enableLoggingFail;
+		return this;
+	}
+
 	public FixtureMonkeyOptionsBuilder defaultArbitraryValidator(ArbitraryValidator arbitraryValidator) {
 		this.defaultArbitraryValidator = arbitraryValidator;
 		return this;
@@ -664,7 +670,8 @@ public FixtureMonkeyOptions build() {
 			this.generateUniqueMaxTries,
 			resolvedJavaConstraintGenerator,
 			this.instantiatorProcessor,
-			this.candidateConcretePropertyResolvers
+			this.candidateConcretePropertyResolvers,
+			this.enableLoggingFail
 		);
 	}
 

diff --git a/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/FixtureMonkeyBuilder.java b/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/FixtureMonkeyBuilder.java
@@ -450,6 +450,11 @@ public FixtureMonkeyBuilder nullableElement(boolean nullableElement) {
 		return this;
 	}
 
+	public FixtureMonkeyBuilder enableLoggingFail(boolean enableLoggingFail) {
+		this.fixtureMonkeyOptionsBuilder.enableLoggingFail(enableLoggingFail);
+		return this;
+	}
+
 	/**
 	 * It is deprecated. Please use {@link InterfacePlugin#interfaceImplements(Matcher, List)} instead.
 	 */

diff --git a/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/tree/ObjectTree.java b/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/tree/ObjectTree.java
@@ -127,7 +127,8 @@ private ArbitraryGeneratorContext generateContext(
 			},
 			objectNode.getLazyPropertyPath(),
 			monkeyGeneratorContext,
-			fixtureMonkeyOptions.getGenerateUniqueMaxTries()
+			fixtureMonkeyOptions.getGenerateUniqueMaxTries(),
+			fixtureMonkeyOptions.isEnableLoggingFail()
 		);
 	}