Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FailoverIntrospector의 enableLoggingFail 옵션을 Introspector들에도 적용할수있을까요? #1066

Closed
HanJaehee opened this issue Oct 21, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@HanJaehee
Copy link
Contributor

HanJaehee commented Oct 21, 2024

Describe the feature you request

1.0.27에서 enableLoggingFail 옵션이 추가되어서 FailoverIntrospector 자체에서 발생하는 warning 로그들은 조절이 가능한 상태인데요.
FailoverIntrospector에 넣는 Introspector들에도 위 옵션을 승계할수있을지 궁금합니다.

(Optional): Suggest A Solution

If the feature request is approved, would you be willing to submit a PR?

Yes (Help can be provided if you need assistance submitting a PR)

@HanJaehee HanJaehee added the enhancement New feature or request label Oct 21, 2024
@seongahjo
Copy link
Contributor

@HanJaehee 님, 안녕하세요.

FailoverIntrospector에 넣는 Introspector들에도 위 옵션을 승계할수있을지 궁금합니다.

단시간내에 계획이 없지만, 장기적으로는 로그를 글로벌하게 관리하는 방향으로 진행하려고 계획은 하고 있습니다.
그전에 첫 단계로 이 이슈를 진행해도 좋을 것 같긴 하네요. 작업이 가능하시다면 PR 올려주시면 감사하겠습니다!

감사합니다.

HanJaehee added a commit to HanJaehee/fixture-monkey that referenced this issue Oct 24, 2024
HanJaehee added a commit to HanJaehee/fixture-monkey that referenced this issue Oct 24, 2024
HanJaehee added a commit to HanJaehee/fixture-monkey that referenced this issue Oct 29, 2024
HanJaehee added a commit to HanJaehee/fixture-monkey that referenced this issue Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants