add FlxTween.flicker #3086
Merged
add FlxTween.flicker #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * The default tween function of flicker tweens | ||
| * @param tween The tween handling the flickering | ||
| */ | ||
| public static function defaultTweenFunction(tween:FlickerTween) |
There was a problem hiding this comment.
The rest of the functions here have explicit returns types on the signature. What is the flixel guideline for return types in function signatures?
There was a problem hiding this comment.
there is no rule on this, I kinda prefer not having it, in more cases, especially here where tweenFunction is well defined
| */ | ||
| public static function defaultTweenFunction(tween:FlickerTween) | ||
| { | ||
| return (tween.time / tween.period) % 1 > tween.ratio; |
There was a problem hiding this comment.
I was curious how you approached handling the ratio. This is pleasantly simple 👍
There was a problem hiding this comment.
at first I had > 0.5 then i wondered what other values would look like
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlxTween based flicker tool. FlxFlicker isn't being deprecated but I don't recommend using it unless someone has a good reason
additions and features:
flicker,isFlickeringandstopFlickeringinstance methods toFlxTweenManagerand static methods toFlxTweenratio: rather than 50-50 split of on/off, can do 80-20 or whateverTo do: add unit test