DSL: add installer stanza
#6660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change namespace for clarity, as we already have Cask::Installer, and are about to add Cask::DSL::Installer. Move to parent because these methods are not DSL-specific.
instead of manual_installer
* document installer :script. install_script was never documented
a toplevel artifact, intended to replace `manual_installer`, which is currently implemented within the `caveats` mini-DSL
This was referenced Oct 14, 2014
|
With regards to the DSL, this is certainly an improvement. In particular, I agree on clearing |
|
Great. This implementation is not especially good, but it passes tests and seems to get the interface (DSL) right. |
rolandwalker
added a commit
that referenced
this pull request
Oct 16, 2014
DSL: add `installer` stanza
This was referenced Oct 21, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install_scriptform toinstaller :scriptinstaller :manual, a toplevel artifact meant to replacemanual_installerwithincaveats