use installer :script in 3 Casks
#6869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove `caskroom_only true` * remove `postflight`
* remove `caskroom_only true` * remove `postflight`
* hoist primary command out of `postflight` into `installer` artifact * this Cask did not use the `caskroom_only` idiom
rolandwalker
added a commit
that referenced
this pull request
Oct 22, 2014
use `installer :script` in 3 Casks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
installeris a very late addition to the DSL because the form was changed from the original proposal (#6660, only available in the latest release 0.45.0).However,
installer :scriptis unlikely to be disruptive, as the change only touches 3 Casks, and themethod_missingwarning will be generated for anyone who tries to use these Casks without updating.Part of the purpose here was to get rid of the old
caskroom_only/postflighthack. After this change,caskroom_onlyis used only once (node-webkit.rb).Enforcing that
caskroom_onlymay not be used in combination with other artifacts is still todo.