Skip to content

Commit

Permalink
ffmpeg: remove options.
Browse files Browse the repository at this point in the history
  • Loading branch information
MikeMcQuaid committed Jan 21, 2019
1 parent 4cb921e commit f75cb09
Showing 1 changed file with 13 additions and 99 deletions.
112 changes: 13 additions & 99 deletions Formula/ffmpeg.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,78 +12,28 @@ class Ffmpeg < Formula
sha256 "2e48a23ff807683a78b1792101e39a39cf6ace0e525afefe7109beb421c19034" => :sierra
end

option "with-chromaprint", "Enable the Chromaprint audio fingerprinting library"
option "with-fdk-aac", "Enable the Fraunhofer FDK AAC library"
option "with-libass", "Enable ASS/SSA subtitle format"
option "with-librsvg", "Enable SVG files as inputs via librsvg"
option "with-libsoxr", "Enable the soxr resample library"
option "with-libssh", "Enable SFTP protocol via libssh"
option "with-tesseract", "Enable the tesseract OCR engine"
option "with-libvidstab", "Enable vid.stab support for video stabilization"
option "with-opencore-amr", "Enable Opencore AMR NR/WB audio format"
option "with-openh264", "Enable OpenH264 library"
option "with-openjpeg", "Enable JPEG 2000 image format"
option "with-openssl", "Enable SSL support"
option "with-rtmpdump", "Enable RTMP protocol"
option "with-rubberband", "Enable rubberband library"
option "with-webp", "Enable using libwebp to encode WEBP images"
option "with-zeromq", "Enable using libzeromq to receive commands sent through a libzeromq client"
option "with-zimg", "Enable z.lib zimg library"
option "with-srt", "Enable SRT library"
option "with-libvmaf", "Enable libvmaf scoring library"
option "with-aom", "Enable AV1 video codec"

deprecated_option "with-libtesseract" => "with-tesseract"

depends_on "nasm" => :build
depends_on "pkg-config" => :build
depends_on "texi2html" => :build

depends_on "freetype"
depends_on "frei0r"
depends_on "lame"
depends_on "libass"
depends_on "libvorbis"
depends_on "libvpx"
depends_on "opencore-amr"
depends_on "opus"
depends_on "rtmpdump"
depends_on "sdl2"
depends_on "snappy"
depends_on "speex"
depends_on "theora"
depends_on "x264"
depends_on "x265"
depends_on "xvid"
depends_on "xz"

depends_on "aom" => :optional
depends_on "chromaprint" => :optional
depends_on "fdk-aac" => :optional
depends_on "fontconfig" => :optional
depends_on "freetype" => :optional
depends_on "frei0r" => :optional
depends_on "game-music-emu" => :optional
depends_on "libass" => :optional
depends_on "libbluray" => :optional
depends_on "libbs2b" => :optional
depends_on "libcaca" => :optional
depends_on "libgsm" => :optional
depends_on "libmodplug" => :optional
depends_on "librsvg" => :optional
depends_on "libsoxr" => :optional
depends_on "libssh" => :optional
depends_on "libvidstab" => :optional
depends_on "libvmaf" => :optional
depends_on "opencore-amr" => :optional
depends_on "openh264" => :optional
depends_on "openjpeg" => :optional
depends_on "openssl" => :optional
depends_on "rtmpdump" => :optional
depends_on "rubberband" => :optional
depends_on "speex" => :optional
depends_on "srt" => :optional
depends_on "tesseract" => :optional
depends_on "two-lame" => :optional
depends_on "wavpack" => :optional
depends_on "webp" => :optional
depends_on "zeromq" => :optional
depends_on "zimg" => :optional

def install
args = %W[
--prefix=#{prefix}
Expand All @@ -107,52 +57,16 @@ def install
--enable-libx265
--enable-libxvid
--enable-lzma
--enable-libfreetype
--enable-frei0r
--enable-libass
--enable-libopencore-amrnb
--enable-libopencore-amrwb
--enable-librtmp
--enable-libspeex
]

args << "--enable-chromaprint" if build.with? "chromaprint"
args << "--enable-frei0r" if build.with? "frei0r"
args << "--enable-libaom" if build.with? "aom"
args << "--enable-libass" if build.with? "libass"
args << "--enable-libbluray" if build.with? "libbluray"
args << "--enable-libbs2b" if build.with? "libbs2b"
args << "--enable-libcaca" if build.with? "libcaca"
args << "--enable-libfdk-aac" if build.with? "fdk-aac"
args << "--enable-libfontconfig" if build.with? "fontconfig"
args << "--enable-libfreetype" if build.with? "freetype"
args << "--enable-libgme" if build.with? "game-music-emu"
args << "--enable-libgsm" if build.with? "libgsm"
args << "--enable-libmodplug" if build.with? "libmodplug"
args << "--enable-libopencore-amrnb" << "--enable-libopencore-amrwb" if build.with? "opencore-amr"
args << "--enable-libopenh264" if build.with? "openh264"
args << "--enable-librsvg" if build.with? "librsvg"
args << "--enable-librtmp" if build.with? "rtmpdump"
args << "--enable-librubberband" if build.with? "rubberband"
args << "--enable-libsoxr" if build.with? "libsoxr"
args << "--enable-libspeex" if build.with? "speex"
args << "--enable-libsrt" if build.with? "srt"
args << "--enable-libssh" if build.with? "libssh"
args << "--enable-libtesseract" if build.with? "tesseract"
args << "--enable-libtwolame" if build.with? "two-lame"
args << "--enable-libvidstab" if build.with? "libvidstab"
args << "--enable-libvmaf" if build.with? "libvmaf"
args << "--enable-libwavpack" if build.with? "wavpack"
args << "--enable-libwebp" if build.with? "webp"
args << "--enable-libzimg" if build.with? "zimg"
args << "--enable-libzmq" if build.with? "zeromq"
args << "--enable-opencl" if MacOS.version > :lion
args << "--enable-openssl" if build.with? "openssl"
args << "--enable-videotoolbox" if MacOS.version >= :mountain_lion

if build.with? "openjpeg"
args << "--enable-libopenjpeg"
args << "--disable-decoder=jpeg2000"
args << "--extra-cflags=" + `pkg-config --cflags libopenjp2`.chomp
end

# These librares are GPL-incompatible, and require ffmpeg be built with
# the "--enable-nonfree" flag, which produces unredistributable libraries
args << "--enable-nonfree" if build.with?("fdk-aac") || build.with?("openssl")

system "./configure", *args
system "make", "install"

Expand Down

4 comments on commit f75cb09

@magsmike
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance options such as "--enable-openssl" coming back?

@SMillerDev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no chance options are coming back. You could propose to include something in the default if it makes sense for the majority though.

@magsmike
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok understood.

Just out of curiosity, can you share why?

I will propose some flags as “defaults” in the proper channels.

@MikeMcQuaid
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, can you share why?

#31510

Please sign in to comment.