sextractor: Support newer compilers by changing finite to isfinite

[Chekov2k]

• [ x] Have you followed the guidelines for contributing?
• [ x] Have you ensured that your commits follow the commit style guide?
• [ x] Have you checked that there aren't other open pull requests for the same formula update/change?
• [ x] Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• [ x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• [ x] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

Works around the following issue:

homebrew-core % brew install sextractor -s
==> Downloading https://formulae.brew.sh/api/formula.jws.json
##O#-  #
==> Downloading https://formulae.brew.sh/api/cask.jws.json
##O#-  #
Warning: sextractor 2.28.0 is already installed and up-to-date.
To reinstall 2.28.0, run:
  brew reinstall sextractor
balzer@akb homebrew-core % brew reinstall sextractor -s
Warning: building from source is not supported!
You're on your own. Failures are expected so don't create any issues, please!
==> Fetching sextractor
==> Downloading https://raw.githubusercontent.com/Homebrew/homebrew-core/8a081cafac89674690eb3f7fcd2c1ee6a24b64ef/Formula/s/se
####################################################################################################################### 100.0%
==> Downloading https://github.com/astromatic/sextractor/archive/refs/tags/2.28.0.tar.gz
==> Downloading from https://codeload.github.com/astromatic/sextractor/tar.gz/refs/tags/2.28.0
# -#O=#    #
==> Reinstalling sextractor
==> ./autogen.sh
==> ./configure --disable-silent-rules --enable-openblas --with-openblas-libdir=/opt/homebrew/opt/openblas/lib --with-openblas
==> make install
Last 15 lines from /Users/balzer/Library/Logs/Homebrew/sextractor/03.make:
#define LM_FINITE finite // ICC, GCC
                  ^
#define LM_FINITE finite // ICC, GCC
                  ^
./lmbc_core.c:324:13: note: include the header <math.h> or explicitly provide a declaration for 'finite'
./compiler.h:63:19: note: expanded from macro 'LM_FINITE'
#define LM_FINITE finite // ICC, GCC
                  ^
1 error generated.
1 error generated.
make[2]: *** [lm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [lmbc.o] Error 1
make[1]: *** [install-recursive] Error 1
make: *** [install-recursive] Error 1

READ THIS: https://docs.brew.sh/Troubleshooting

[SMillerDev]

Has this been submitted upstream?

[Chekov2k]

Upstream hasn't released a version in years and would need checking against a whole range of old/ancient compilers. I felt it would be easier to patch it here since the range of compilers that need supporting is fairly limited compared to upstream.

[Chekov2k]

There is an upstream bug report opened in 2022 as well with no traction: astromatic/sextractor#27

[SMillerDev]

If upstream stopped responding we should also deprecate this.

[Chekov2k]

Bit harsh ;) Gonna raise an MR on upstream as well and see if they respond

[SMillerDev]

Bit harsh ;) Gonna raise an MR on upstream as well and see if they respond

It's either that or we keep putting bandaids on a corpse hoping it'll live.

[Chekov2k]

Don't get me wrong, I get your point of view. I'll try and get that fixed upstream.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[github-actions]

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

[chenrui333]

  compiler.h:63:10: fatal error: cmath: No such file or directory
     63 | #include <cmath>
        |          ^~~~~~~
  compilation terminated.
  In file included from lm.c:59:
  compiler.h:63:10: fatal error: cmath: No such file or directory
     63 | #include <cmath>
        |          ^~~~~~~
  compilation terminated.

[Chekov2k]

Well that took a few attempts but works now

[Chekov2k]

Added an Apple check in the sextractor patch so now it works for Linux like before

[cho-m]

Isn't the upstream code in C (<math.h>) not C++ (<cmath>)?

[Chekov2k]

I went with the header this page suggested: https://en.cppreference.com/w/cpp/numeric/math/isfinite

[Chekov2k]

The upstream maintainers replied so going to look at that code hopefully as well. I can try changing to math.h tonight

[Chekov2k]

Changed it to math.h

[SMillerDev]

If this applies cleanly, could you make the patch block use the upstream commit instead of a DATA block?

[Chekov2k]

Let me read up on how to do that!

[Chekov2k]

Should be done now

[SMillerDev]

One last thing

[SMillerDev]

Thanks @Chekov2k ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

[Chekov2k]

No problem :)