Switch finite to std::isfinite for ICC and GCC #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chekov2k
force-pushed
the
master
branch
8 times, most recently
from
51404d2
to
8c65b0c
Compare
|
Would be nice to get some traction on this one |
|
Thanks for the PR and sorry for the delay. I will take care of this tonight. |
|
Thank you! The home-brew CI shows it works fine on Mac OS X for the last few major releases so should not break anything for anyone |
This supports latest compilers on Mac OS X, see Homebrew/homebrew-core#181246
|
Thank you @Chekov2k for the PR. It might worth a release. |
|
I haven't configured any GitHub CI yet but can give it a go ;) Should be fairly similar to GitLab... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports latest compilers on Mac OS X, see Homebrew/homebrew-core#181246