Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bats-core 0.4.0 (new formula) #20073

Closed
wants to merge 1 commit into from

Conversation

btamayo
Copy link
Contributor

@btamayo btamayo commented Oct 31, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

bats-core is the revival and the happy, growing continuation of the original bats. As there are a good number of bats users and there's been momentum on users migrating to bats-core, we thought it would be prudent to update package manager formulae and release long-anticipated updates as soon as possible.

Side note: There are currently no naming conflicts with this formula and the pre-existing bats formula. But, if the maintainers could give me some advice on how one would "replace" an existing formula that's been seemingly abandoned ~3 years or so, I would be thankful. I'm not sure how common this situation is, and if there are already guidelines on it. Thanks!

@ilovezfs ilovezfs added the new formula PR adds a new formula to Homebrew/homebrew-core label Oct 31, 2017
@woodruffw
Copy link
Member

woodruffw commented Nov 1, 2017

First of all, thanks for the PR!

Based on the README, this release isn't considered stable yet:

  1. Roadmap 1.0: There are already existing high-quality PRs, and often-requested features and issues, especially here at dockward 0.0.3 (new formula) #196. Leverage these and consolidate into a single roadmap.
  2. Create or choose a fork or mirror of this repo to use as the new mainline: Repoint existing PRs (whichever ones are possible) to the new mainline, get that repo to a stable 1.0. IMO we should create an organization and grant 2-3 people admin and write access.

Per our formulae guidelines, we can't accept new formulae without a stable version.

I'll leave some review notes above for when this does get to a stable release. Sorry, and thanks again!

@woodruffw woodruffw closed this Nov 1, 2017
url "https://github.com/bats-core/bats-core/archive/v0.4.0.tar.gz"
sha256 "e3b65b50a26e3f0c33b5d0a57d74101acf096e39473294d4840635ca6206fec7"

bottle :unneeded
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop this line -- we prefer to build bottles of shell-only packages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Or maybe not...I see that we allowed for :unneeded in the original bats.)

system "./install.sh", prefix
end

def caveats; <<~EOS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't usually like long caveats blobs like this. If bats and bats-core can't play nice when installed at the same time, a conflicts_with statement would be a little cleaner and catch potential mistakes earlier.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an example:

conflicts_with "bats", :because => "both install a `bats` binary"

@btamayo
Copy link
Contributor Author

btamayo commented Nov 2, 2017

@woodruffw Fantastic I really appreciate those tips, thanks! (FWIW There's no new code, this formula simply changes the download origin of the package to the new repo), but I'll definitely update the formula and incorporate this feedback for our stable release! :)

@woodruffw
Copy link
Member

Awesome!

FWIW, I'm 👍 on removing bats and aliasing bats-core to it when this is considered stable -- see #20094 as an example of this.

@btamayo
Copy link
Contributor Author

btamayo commented Nov 2, 2017

@woodruffw Thank you! That'll be a huge help :D

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
@ilovezfs ilovezfs added the superseded PR was replaced by another PR label Jun 14, 2018
@ilovezfs
Copy link
Contributor

Superseded by #28977

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core superseded PR was replaced by another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants