bats-core 1.0.1 (new formula) #28977

kenden · 2018-06-13T09:38:29Z

This is an updated version from closed PR #20073
(keeping the commit from @btamayo)

Now that bats-core has a stable release, it is time to create a formula for it.

I propose creating an alias bats and removing the existing formula bats
once bats-core has had a few more stable releases.

Have you followed the guidelines for contributing?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

SMillerDev · 2018-06-13T09:49:58Z

Maybe alias bats -> bats-core and then rename the original bats to [email protected]? @ilovezfs probably has an opinion on this.

kenden · 2018-06-13T10:03:10Z

@SMillerDev Thanks. Could you check my renaming of the original bats? I'm unsure if I need to change the file content also.

SMillerDev · 2018-06-13T11:09:26Z

@kenden Jenkins says you do 😉. Also, by convention the versioned formula would be called [email protected] with the class BatsAt04

kenden · 2018-06-13T13:56:59Z

[email protected] cannot have:

keg_only :versioned_formula
(else it fails to install with:
"This formula is keg-only, which means it was not symlinked into /usr/local,
because this is an alternate version of another formula.")
conflicts_with "bats-core"
(Jenkins does not allow it for versioned formulae. Although, in this case, I think it would be correct and Jenkins is wrong)
none of those (neither conflicts_with or keg_only)
(else it has a problem if bats-core is installed already)

So, I suggest renaming bats to [email protected],
and also naming bats-core to [email protected]
It this case, keg_only :versioned_formula should work.
@SMillerDev @ilovezfs, @woodruffw what do you think?

woodruffw · 2018-06-13T13:58:19Z

Formula/bats-core.rb

+  bottle :unneeded
+
+  conflicts_with "[email protected]",
+    :because => "[email protected] and bats-core install a `bats` executable"


Nit: "both install a bats executable" is slightly shorter, and is what we use elsewhere for this type of conflict 🙂

Fixed, there is no bats formula to conflict with any more, so I removed the block

ilovezfs · 2018-06-13T14:03:32Z

We probably don't need the @ formula at all.

woodruffw · 2018-06-13T14:07:36Z

I agree with @ilovezfs -- unmaintained project + new, maintained fork that's compatible suggests removal and aliasing to me.

kenden · 2018-06-13T14:26:40Z

@woodruffw I removed the old bats formula, added bats-core and aliased it to bats. All checks pass.

ilovezfs · 2018-06-13T14:27:41Z

formula_renames.json too

kenden · 2018-06-13T15:47:09Z

@woodruffw, how does it get merged?

ilovezfs · 2018-06-13T16:20:25Z

After some investigation, I'm actually a bit concerned with just handling this as a rename. Based on sstephenson/bats#150, bats-core has not yet received an official nod from the original upstream, and despite sstephenson/bats#150 (comment), there is some anecdotal evidence that it is not: sobolevn/git-secret#203

For now I'd be more comfortable treating this just as a new formula, and leave the original bats in place. We can always revisit that later.

CC @mislav @sstephenson for any thoughts!

kenden · 2018-06-13T18:08:35Z

@ilovezfs I agree, that's what I wrote in the PR description originally.

kenden · 2018-06-13T20:10:25Z

@ilovezfs @SMillerDev @woodruffw I reverted, keeping the original bats and just adding bats-core.

woodruffw · 2018-06-13T20:27:16Z

Thanks! Sorry about the round-about 🙂

…

On June 13, 2018 4:10:28 PM EDT, Quentin Nerden ***@***.***> wrote: @ilovezfs @SMillerDev @woodruffw I reverted, keeping the original bats and just adding bats-core.

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

jasonkarns · 2018-06-13T21:13:46Z

Formula/bats.rb

@@ -3,10 +3,11 @@ class Bats < Formula
  homepage "https://github.com/sstephenson/bats"
  url "https://github.com/sstephenson/bats/archive/v0.4.0.tar.gz"
  sha256 "480d8d64f1681eee78d1002527f3f06e1ac01e173b761bc73d0cf33f4dc1d8d7"
-  head "https://github.com/sstephenson/bats.git"


Reason to remove ability to install --HEAD ?

I re-added it

jasonkarns · 2018-06-13T21:14:07Z

Formula/bats-core.rb

+  desc "Bash Automated Testing System"
+  homepage "https://github.com/bats-core/bats-core"
+  url "https://github.com/bats-core/bats-core/archive/v1.0.1.tar.gz"
+  sha256 "821626f1e5058a4f25a95722399b460942f27535186a815a279e518b503f8de7"


Can we add head to support --HEAD installs?

@jasonkarns I can, but CONTRIBUTING.md
says to run
$ brew audit --new-formula bats-core
which then breaks with:

bats-core: * Formulae should not have a HEAD spec Error: 1 problem in 1 formula

Trying anyway, maybe the jenkins config differs.

No, Jenkins does not like it for new Formulae. Removing head from bats-core.

ilovezfs · 2018-06-14T07:57:53Z

@btamayo @kenden Thanks for your first contributions to Homebrew! You're awesome. 🦇

kenden · 2018-06-14T08:26:52Z

@ilovezfs I'm glad it's merged.
One note: I didn't see that "Allow edits from maintainers" checked-by-default checkbox on the PR. Thanks for adding changes, but please don't use git rebase on other people's PRs.
The PR's commits should look like that:

2bf55e7 - author ilovezfs - Update test in bats-core.rb
f27f255c - author kenden - Replace caveats block by conflicts_with
7d36a405 - author - kenden - Update bats-core formula to version 1.0.1
0863a884 - author btamayo - bats-core 0.4.0 (new formula)

Thanks!

ilovezfs · 2018-06-14T08:29:31Z

@kenden we squash PRs down to one commit per formula per PR in virtually all cases, and certainly always in new formula PRs.

kenden · 2018-06-14T08:38:36Z

@ilovezfs It makes sense, but it didn't happen this time:
Homebrew:3d822c7944ebcf654fdf4fcd65d8d0b0353807d6...master
It's not one commit, but 2, and changed.

ilovezfs · 2018-06-14T08:39:54Z

@kenden I said one commit per formula ;)

mislav · 2018-06-14T10:27:56Z

For now I'd be more comfortable treating this just as a new formula, and leave the original bats in place. We can always revisit that later.

Good call. bats-core is an unofficial successor to bats. I'm 👍 for having a new formula that is marked as conflicts with bats.

kenden mentioned this pull request Jun 13, 2018

Update or create bats formula on homebrew-core bats-core/bats-core#11

Closed

kenden force-pushed the new-bats-core-formula branch 2 times, most recently from 9a0652d to 41e035f Compare June 13, 2018 09:44

ilovezfs requested a review from woodruffw June 13, 2018 11:04

ilovezfs added the formula rename PR or issue relates to changing a formula's name label Jun 13, 2018

kenden force-pushed the new-bats-core-formula branch 6 times, most recently from e87db7e to bb50b91 Compare June 13, 2018 13:22

woodruffw requested changes Jun 13, 2018

View reviewed changes

kenden force-pushed the new-bats-core-formula branch from bb50b91 to e2faabb Compare June 13, 2018 14:07

kenden force-pushed the new-bats-core-formula branch from e2faabb to 6a2ac1b Compare June 13, 2018 14:15

kenden changed the title ~~New bats-core formula~~ New bats-core formula && remove bats formula Jun 13, 2018

kenden force-pushed the new-bats-core-formula branch from 6a2ac1b to c94cd91 Compare June 13, 2018 14:31

woodruffw approved these changes Jun 13, 2018

View reviewed changes

ilovezfs changed the title ~~New bats-core formula && remove bats formula~~ bats-core 1.0.1 (new formula) Jun 13, 2018

ilovezfs added new formula PR adds a new formula to Homebrew/homebrew-core and removed formula rename PR or issue relates to changing a formula's name labels Jun 13, 2018

kenden force-pushed the new-bats-core-formula branch from c94cd91 to e539d0a Compare June 13, 2018 20:06

jasonkarns reviewed Jun 13, 2018

View reviewed changes

kenden force-pushed the new-bats-core-formula branch from b5151e4 to f27f255 Compare June 13, 2018 22:15

ilovezfs added the do not merge label Jun 14, 2018

btamayo and others added 2 commits June 14, 2018 00:20

bats-core 0.4.0 (new formula)

24304ff

bats: conflicts with bats-core

b98c050

ilovezfs force-pushed the new-bats-core-formula branch from ec7cae0 to b98c050 Compare June 14, 2018 07:21

ilovezfs removed the do not merge label Jun 14, 2018

ilovezfs merged commit 30c6ae4 into Homebrew:master Jun 14, 2018

ilovezfs mentioned this pull request Jun 14, 2018

bats-core 0.4.0 (new formula) #20073

Closed

4 tasks

kenden deleted the new-bats-core-formula branch June 14, 2018 08:39

lock bot added the outdated PR was locked due to age label Jul 14, 2018

lock bot locked as resolved and limited conversation to collaborators Jul 14, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bats-core 1.0.1 (new formula) #28977

bats-core 1.0.1 (new formula) #28977

kenden commented Jun 13, 2018 •

edited

Loading

SMillerDev commented Jun 13, 2018

kenden commented Jun 13, 2018

SMillerDev commented Jun 13, 2018

kenden commented Jun 13, 2018 •

edited

Loading

woodruffw Jun 13, 2018

kenden Jun 13, 2018 •

edited

Loading

ilovezfs commented Jun 13, 2018

woodruffw commented Jun 13, 2018

kenden commented Jun 13, 2018

ilovezfs commented Jun 13, 2018

kenden commented Jun 13, 2018

ilovezfs commented Jun 13, 2018 •

edited

Loading

kenden commented Jun 13, 2018

kenden commented Jun 13, 2018

woodruffw commented Jun 13, 2018 via email

jasonkarns Jun 13, 2018

kenden Jun 13, 2018

jasonkarns Jun 13, 2018

kenden Jun 13, 2018 •

edited

Loading

kenden Jun 13, 2018 •

edited

Loading

ilovezfs commented Jun 14, 2018

kenden commented Jun 14, 2018 •

edited

Loading

ilovezfs commented Jun 14, 2018

kenden commented Jun 14, 2018 •

edited

Loading

ilovezfs commented Jun 14, 2018

mislav commented Jun 14, 2018

bats-core 1.0.1 (new formula) #28977

bats-core 1.0.1 (new formula) #28977

Conversation

kenden commented Jun 13, 2018 • edited Loading

SMillerDev commented Jun 13, 2018

kenden commented Jun 13, 2018

SMillerDev commented Jun 13, 2018

kenden commented Jun 13, 2018 • edited Loading

woodruffw Jun 13, 2018

Choose a reason for hiding this comment

kenden Jun 13, 2018 • edited Loading

Choose a reason for hiding this comment

ilovezfs commented Jun 13, 2018

woodruffw commented Jun 13, 2018

kenden commented Jun 13, 2018

ilovezfs commented Jun 13, 2018

kenden commented Jun 13, 2018

ilovezfs commented Jun 13, 2018 • edited Loading

kenden commented Jun 13, 2018

kenden commented Jun 13, 2018

woodruffw commented Jun 13, 2018 via email

jasonkarns Jun 13, 2018

Choose a reason for hiding this comment

kenden Jun 13, 2018

Choose a reason for hiding this comment

jasonkarns Jun 13, 2018

Choose a reason for hiding this comment

kenden Jun 13, 2018 • edited Loading

Choose a reason for hiding this comment

kenden Jun 13, 2018 • edited Loading

Choose a reason for hiding this comment

ilovezfs commented Jun 14, 2018

kenden commented Jun 14, 2018 • edited Loading

ilovezfs commented Jun 14, 2018

kenden commented Jun 14, 2018 • edited Loading

ilovezfs commented Jun 14, 2018

mislav commented Jun 14, 2018

kenden commented Jun 13, 2018 •

edited

Loading

kenden commented Jun 13, 2018 •

edited

Loading

kenden Jun 13, 2018 •

edited

Loading

ilovezfs commented Jun 13, 2018 •

edited

Loading

kenden Jun 13, 2018 •

edited

Loading

kenden Jun 13, 2018 •

edited

Loading

kenden commented Jun 14, 2018 •

edited

Loading

kenden commented Jun 14, 2018 •

edited

Loading