-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate repository #526
Deprecate repository #526
Conversation
I performed the deprecation testing on https://pypi.org/project/dbio-cli/. version 1.0.0 is a known good build, version 1.5.5 is the version that fails when you try to install. |
85d4b0f
to
9ae58ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should databiosphere/azul#2897
be in the title? Seems like it should be a link in a comment instead.
Approved.
(.venv) daniel@Crispin ~/dcp-cli $ pip install git+https://github.com/HumanCellAtlas/dcp-cli.git@issues/amar/2897-RIP-cli
Collecting git+https://github.com/HumanCellAtlas/dcp-cli.git@issues/amar/2897-RIP-cli
Cloning https://github.com/HumanCellAtlas/dcp-cli.git (to revision issues/amar/2897-RIP-cli) to /private/var/folders/8s/9dwlx2rj1n39n7mdk610dhj40000gn/T/pip-req-build-3qrgv4vs
Running command git clone -q https://github.com/HumanCellAtlas/dcp-cli.git /private/var/folders/8s/9dwlx2rj1n39n7mdk610dhj40000gn/T/pip-req-build-3qrgv4vs
Running command git checkout -b issues/amar/2897-RIP-cli --track origin/issues/amar/2897-RIP-cli
Switched to a new branch 'issues/amar/2897-RIP-cli'
Branch 'issues/amar/2897-RIP-cli' set up to track remote branch 'issues/amar/2897-RIP-cli' from 'origin'.
Running command git submodule update --init --recursive -q
ERROR: Command errored out with exit status 1:
command: /Users/daniel/dcp-cli/.venv/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/8s/9dwlx2rj1n39n7mdk610dhj40000gn/T/pip-req-build-3qrgv4vs/setup.py'"'"'; __file__='"'"'/private/var/folders/8s/9dwlx2rj1n39n7mdk610dhj40000gn/T/pip-req-build-3qrgv4vs/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base pip-egg-info
cwd: /private/var/folders/8s/9dwlx2rj1n39n7mdk610dhj40000gn/T/pip-req-build-3qrgv4vs/
Complete output (3 lines):
The HCA module is deprecated, for assistance with accessing data please refer to the data-browser quick start guide at https://data.humancellatlas.org/guides/quick-start-guide
----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
WARNING: You are using pip version 19.2.3, however version 21.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
9ae58ad
to
0728afe
Compare
@danielsotirhos having the issue link the in PR title is wrong (I did not change it from the default oops), I wanted the link to be only within the commit message. I'm all for removing it from the commit message, but it does seem useful to have. I'll leave it within the commit message for now, and @hannes-ucsc so he can 👀 |
README.rst
Outdated
@@ -1,3 +1,7 @@ | |||
DEPRECATED | |||
========== | |||
This repository is deprecated, for assistance with accessing data please refer to the `data-browser quick start guide. <https://data.humancellatlas.org/guides/quick-start-guide>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repository is deprecated, for assistance with accessing data please refer to the `data-browser quick start guide. <https://data.humancellatlas.org/guides/quick-start-guide>`_ | |
This repository has been deprecated. For information about accessing Human Cell Atlas data please refer to the `data-browser quick start guide. <https://data.humancellatlas.org/guides/quick-start-guide>`_ |
setup.py
Outdated
import sys | ||
|
||
if set(sys.argv).isdisjoint({'sdist', 'bdist_wheel', '--name', '--version'}): | ||
sys.exit('\nThe HCA module is deprecated, for assistance with accessing data ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After fixing the spelling, go ahead and merge.
README.rst
Outdated
@@ -1,3 +1,7 @@ | |||
DEPRECATED | |||
========== | |||
This repository has been deprecated. For information about accessing Human Cell Atlas data please refer to the `data-browser quick start guide. <https://data.humancellatlas.org/guides/quick-start-guide>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repository has been deprecated. For information about accessing Human Cell Atlas data please refer to the `data-browser quick start guide. <https://data.humancellatlas.org/guides/quick-start-guide>`_ | |
This repository has been deprecated. For information about accessing Human Cell Atlas data please refer to the `Data Browser quick start guide. <https://data.humancellatlas.org/guides/quick-start-guide>`_ |
setup.py
Outdated
if set(sys.argv).isdisjoint({'sdist', 'bdist_wheel', '--name', '--version'}): | ||
sys.exit('\nThis repository has been deprecated. For information about ' | ||
'accessing Human Cell Atlas data please refer to the ' | ||
'`data-browser quick start guide. ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
32501dd
to
56ab3bb
Compare
Add deprecation within README.md
Remove uploading of .whl to pypi to force building from source
Does not allow installation via
pip install hca
see warning attachedDoes allow installation via
pip install hca==7.0.0