[Refactor] Memory optimizing with OOP Refactoring #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Feat] Optimize UI (#3) - Disable closing `support window` - Layout setting according to the position of the toolWindow - Embed console view on `Result Area` - Refactoring for Clean Code and Object-oriented Coding * [Fix] Verification error (#5) Fixed an error that failed verification due to carriage return characters by deleting all carriage return characters. Signed-off-by: Hyeon-Uk <[email protected]>
- according to BOJ's public homepage, this feature is not available because Baekjun has banned scraping.
- Components in EditorPanel uses same instance, such as `JLabel` and `JBorder` - These components are immutable objects, so by creating one and sharing it, we can save memory. - So, I apply Flyweight pattern Signed-off-by: Hyeon-Uk <[email protected]>
- according to Single Responsibility Principle in `Object Oriented Programming Principles`, They must have only their responsibility. - so seperate responsibility and Use IOC&DI with interface
Hyeon-Uk
added a commit
that referenced
this pull request
May 11, 2024
* [Refactor] Memory optimizing with OOP Refactoring (#11) * [Refactor] Apply Flyweight Pattern for UI Memory Optimization - Components in EditorPanel uses same instance, such as `JLabel` and `JBorder` - These components are immutable objects, so by creating one and sharing it, we can save memory. - So, I apply Flyweight pattern * [Refactor] Seperate Component with responsibility - according to Single Responsibility Principle in `Object Oriented Programming Principles`, They must have only their responsibility. - so seperate responsibility and Use IOC&DI with interface * [Feat] Add `remove all action` * [Refactor] Remove ToolbarPanel Dependency in mainViewPanel In mainView, toolbarPanel is not neccessary. so remove it. * [Refactor] Change ThreadStore's Creational Patterns, Singleton to Normal Object for making tests easier * [Refactor] Restructure to Enable DI in ToolWindowFactory and Remove Singleton Pattern * [Test] Add Action Tests - AddTest - RemoveAllTest - RemoveTest - RunAllTest - RunTest - StopAllTest * [Refactor] Remove dependencies each editor components from EditorPanel using interface and abstract class * [Test] Adding EditorPanel tests * [Test] Adding MyTestList tests * [Refactor] Remove dependencies subTestList from TestListPanel using interface and abstract class * [Test] Adding TestListPanel tests * [Test] Adding MainView tests --------- Signed-off-by: Hyeon-Uk <[email protected]>
Merged
Hyeon-Uk
added a commit
that referenced
this pull request
May 11, 2024
* [Refactor] Memory optimizing with OOP Refactoring (#11) * [Refactor] Apply Flyweight Pattern for UI Memory Optimization - Components in EditorPanel uses same instance, such as `JLabel` and `JBorder` - These components are immutable objects, so by creating one and sharing it, we can save memory. - So, I apply Flyweight pattern * [Refactor] Seperate Component with responsibility - according to Single Responsibility Principle in `Object Oriented Programming Principles`, They must have only their responsibility. - so seperate responsibility and Use IOC&DI with interface * [Feat] Add `remove all action` * [Refactor] Remove ToolbarPanel Dependency in mainViewPanel In mainView, toolbarPanel is not neccessary. so remove it. * [Refactor] Change ThreadStore's Creational Patterns, Singleton to Normal Object for making tests easier * [Refactor] Restructure to Enable DI in ToolWindowFactory and Remove Singleton Pattern * [Test] Add Action Tests - AddTest - RemoveAllTest - RemoveTest - RunAllTest - RunTest - StopAllTest * [Refactor] Remove dependencies each editor components from EditorPanel using interface and abstract class * [Test] Adding EditorPanel tests * [Test] Adding MyTestList tests * [Refactor] Remove dependencies subTestList from TestListPanel using interface and abstract class * [Test] Adding TestListPanel tests * [Test] Adding MainView tests --------- Signed-off-by: Hyeon-Uk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to Single Responsibility Principle in
Object Oriented Programming Principles, They must have only their responsibility.so seperate responsibility and Use IOC&DI with interface