Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen xlrd requirement #572

Merged
merged 6 commits into from
Aug 15, 2021
Merged

Loosen xlrd requirement #572

merged 6 commits into from
Aug 15, 2021

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Aug 14, 2021

Please confirm that this PR has done the following:

  • Tests Added (N/A)
  • Documentation Added (N/A)
  • Name of contributors Added to AUTHORS.rst (N/A)
  • Description in RELEASE_NOTES.md Added

Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)

Please add a single line in the release notes similar to the following:

- (#XX)[http://link-to-pr.com] Added feature which does something

Description of PR

Loosen the pinning of xlrd. The pin isn't needed and it's causing issues for downstream users (e.g. attempts to make openscm-runner a conda package conda-forge/staged-recipes#15573 (comment)). It would be great if these changes could be propagated to conda and pypi fairly quickly as a bug fix.

@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #572 (7fd9c52) into main (bd6fb43) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #572   +/-   ##
=====================================
  Coverage   93.7%   93.7%           
=====================================
  Files         50      50           
  Lines       5332    5334    +2     
=====================================
+ Hits        4997    4999    +2     
  Misses       335     335           
Impacted Files Coverage Δ
setup.py 0.0% <ø> (ø)
pyam/core.py 94.3% <100.0%> (ø)
pyam/utils.py 91.6% <100.0%> (+<0.1%) ⬆️
tests/test_io.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd6fb43...7fd9c52. Read the comment docs.

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to not work with xlrd==2.0.0 - maybe require xlrd>=2.0.1 instead?

setup.py Show resolved Hide resolved
@znicholls
Copy link
Collaborator Author

This seems to not work with xlrd==2.0.0 - maybe require xlrd>=2.0.1 instead?

Had to make some tweaks to make sure engine passing worked, let's see what the CI says

@danielhuppmann danielhuppmann added the dependencies Pull requests that update a dependency file label Aug 14, 2021
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @znicholls!

RELEASE_NOTES.md Outdated Show resolved Hide resolved
Co-authored-by: Daniel Huppmann <[email protected]>
@znicholls znicholls merged commit 4cf3b98 into IAMconsortium:main Aug 15, 2021
@znicholls znicholls deleted the unpin-xlrd branch August 15, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants