Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flask-restx 0.3.0 doesn't work with flask 2.0 #52

Merged
merged 1 commit into from
May 12, 2021
Merged

flask-restx 0.3.0 doesn't work with flask 2.0 #52

merged 1 commit into from
May 12, 2021

Conversation

xuhdev
Copy link
Contributor

@xuhdev xuhdev commented May 11, 2021

Looks like we hit flask's release spot: flask 2.0 was released earlier
today two hours ago, which are within the window in which we released a
new MAX Base version after test. Fix flask < 2.0 for now.

Looks like we hit flask's release spot: flask 2.0 was released earlier
today two hours ago, which are within the window in which we released a
new MAX Base version after test. Fix flask < 2.0 for now.
@xuhdev
Copy link
Contributor Author

xuhdev commented May 11, 2021

See python-restx/flask-restx#308

@xuhdev
Copy link
Contributor Author

xuhdev commented May 12, 2021

The branch build failed but it doesn't matter -- it was caused by us having exceeded Docker hub rate limit. The pull request build passed and it is ready to be merged.

Copy link
Member

@SSaishruthi SSaishruthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch. LGTM

@xuhdev xuhdev merged commit f9dfa72 into master May 12, 2021
@xuhdev xuhdev deleted the flask branch May 12, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants