Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump max-base to v1.5.0 #170

Merged
merged 2 commits into from
May 12, 2021
Merged

Bump max-base to v1.5.0 #170

merged 2 commits into from
May 12, 2021

Conversation

xuhdev
Copy link
Contributor

@xuhdev xuhdev commented May 7, 2021

Close #168

@xuhdev xuhdev closed this May 10, 2021
@xuhdev xuhdev reopened this May 10, 2021
@xuhdev xuhdev force-pushed the max-base branch 2 times, most recently from e650222 to 009b2cd Compare May 11, 2021 19:01
@xuhdev xuhdev closed this May 11, 2021
@xuhdev xuhdev reopened this May 11, 2021
@xuhdev xuhdev marked this pull request as ready for review May 11, 2021 23:16
@@ -14,7 +14,7 @@
# limitations under the License.
#

FROM quay.io/codait/max-base:v1.4.2
FROM quay.io/codait/max-base:v1.5.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to pull this.

$ docker pull quay.io/codait/max-base:v1.5.0
Error response from daemon: unknown: Tag v1.5.0 was deleted or has expired. To pull, revive via time machine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just deleted v1.5.0 because we hit a lucky incompatible flask release during which the image was building: IBM/MAX-Base#52

@xuhdev xuhdev closed this May 12, 2021
@xuhdev xuhdev reopened this May 12, 2021
@xuhdev xuhdev requested a review from SSaishruthi May 12, 2021 08:52
Copy link
Member

@SSaishruthi SSaishruthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuhdev xuhdev merged commit 97c44c6 into master May 12, 2021
@xuhdev xuhdev deleted the max-base branch May 12, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image has CVE security issues
3 participants