Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better 'use strict'; #71

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Better 'use strict'; #71

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81ebe56
Revert "Add @@PLUGINSTART-USE-STRICT@@ Replacement"
Jan 18, 2019
0221b7b
change in order to facilitate 'use strict' usage
Jan 18, 2019
807433e
Revert "change in order to facilitate 'use strict' usage"
Jan 18, 2019
a6c6eb6
change in order to facilitate 'use strict' usage
Jan 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
# 1. indentation caused by the "function wrapper()" doesn't apply to the plugin code body
# 2. the wrapper is formatted correctly for removal by the IITC Mobile android app
pluginWrapperStart = """
function wrapper(plugin_info) {
function wrapper(plugin_info) { 'use strict';
// ensure plugin framework is there, even if iitc is not yet loaded
if(typeof window.plugin !== 'function') window.plugin = function() {};

Expand All @@ -78,8 +78,6 @@

"""

pluginWrapperStartUseStrict = pluginWrapperStart.replace("{\n", "{\n\"use strict\";\n", 1)

pluginWrapperEnd = """
setup.info = plugin_info; //add the script info data to the function as a property
if(!window.bootPlugins) window.bootPlugins = [];
Expand Down Expand Up @@ -143,7 +141,6 @@ def doReplacements(script, updateUrl, downloadUrl, pluginName=None):

script = script.replace('@@METAINFO@@', pluginMetaBlock)
script = script.replace('@@PLUGINSTART@@', pluginWrapperStart)
script = script.replace('@@PLUGINSTART-USE-STRICT@@', pluginWrapperStartUseStrict)
script = script.replace('@@PLUGINEND@@', pluginWrapperEnd)

script = re.sub('@@INCLUDERAW:([0-9a-zA-Z_./-]+)@@', loaderRaw, script)
Expand Down