Better 'use strict'; #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 18, 2019 17:27
This reverts commit 0d571f4.
`'use strict';` have to be inside of wrapper function, but before any other statement
johnd0e
referenced
this pull request
Jan 18, 2019
The replacement is the standard PLUGINSTART code followed by "use strict";. by @hayeswise iitc-project/ingress-intel-total-conversion#1187 #2
added 2 commits
January 18, 2019 17:55
This reverts commit 0221b7b.
`'use strict';` have to be inside of wrapper function, but before any other statement
modos189
force-pushed
the
master
branch
3 times, most recently
from
a34b800
to
7b9edd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nowadays there are no reasons why not use
'use strict';in all our scripts.We have 0d571f4, but imho that was not good, as we want strict for ALL standard plugins.
So instead of separate macro
@@PLUGINSTART-USE-STRICT@@it's more proper (and simple) just modify wrapper for all plugins (after Move wrapper template to separate file #238).But before we can make this modifications - we have to make sure that code itself is ready for strict mode.