Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR1119 Review #1

Merged
merged 34 commits into from
May 3, 2024
Merged

PR1119 Review #1

merged 34 commits into from
May 3, 2024

Commits on Apr 3, 2024

  1. [REF] Move DWI specific functions from filemanip.py utils to dwi pr…

    …eprocessing utils (aramis-lab#1116)
    
    * Move DWI specific functions from filemanip utils to dwi utils preproc pipeline utils
    
    * Fix typing that works only for Python >= 3.10
    
    * Clean api
    NicolasGensollen authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    3739be3 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Bump pillow from 10.2.0 to 10.3.0 (aramis-lab#1118)

    Bumps [pillow](https://github.com/python-pillow/Pillow) from 10.2.0 to 10.3.0.
    - [Release notes](https://github.com/python-pillow/Pillow/releases)
    - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
    - [Commits](python-pillow/Pillow@10.2.0...10.3.0)
    
    ---
    updated-dependencies:
    - dependency-name: pillow
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Apr 4, 2024
    Configuration menu
    Copy the full SHA
    f0ae75b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    da22c53 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. [DOC] Add FWHM definition to glossary (aramis-lab#1123)

    * add definition for FWHM
    
    * add link for FWHM
    AliceJoubert authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    041fb4a View commit details
    Browse the repository at this point in the history
  2. [DOC] Add SUVR definition in glossary (aramis-lab#1124)

    * add definition for SUVR in glossary and link in ML_prepareSVM description
    
    * Update docs/glossary.md
    
    ---------
    
    Co-authored-by: Gensollen <[email protected]>
    AliceJoubert and NicolasGensollen authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    93120eb View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Configuration menu
    Copy the full SHA
    5d9710b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4b1c2a4 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. [ENH] Check that BIDS folders have a dataset_description.json file (a…

    …ramis-lab#1127)
    
    * Check that BIDS folders have a dataset_description.json file
    
    * make the _check_bids_is_not_empty function a bit more robust
    NicolasGensollen authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    645fd8c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e63d4eb View commit details
    Browse the repository at this point in the history
  3. [MAINT] Change to regex for subject conversation to RID (aramis-lab#1133

    )
    
    * Use of regex for subject conversion to RID and modification of associated unit tests
    
    * test lint
    AliceJoubert authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    7d2819a View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. [REF] Encode names of dataset as an enum (aramis-lab#1134)

    * Use an enum for the study names
    
    * update unit tests
    
    * forgot one
    NicolasGensollen authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    bc7e7ff View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Configuration menu
    Copy the full SHA
    d7da4ae View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Bump idna from 3.6 to 3.7 (aramis-lab#1138)

    Bumps [idna](https://github.com/kjd/idna) from 3.6 to 3.7.
    - [Release notes](https://github.com/kjd/idna/releases)
    - [Changelog](https://github.com/kjd/idna/blob/master/HISTORY.rst)
    - [Commits](kjd/idna@v3.6...v3.7)
    
    ---
    updated-dependencies:
    - dependency-name: idna
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    4dc5bbb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e565fba View commit details
    Browse the repository at this point in the history
  3. [ENH] Refactor Freesurfer pipelines architecture (aramis-lab#1120)

    * refactor freesurfer pipelines
    
    * add forgotten cli
    
    * use absolute imports in task definitions
    
    * allow string or Path for get_subject_id
    
    * fix folder creation in init_input_node
    NicolasGensollen authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    81e0586 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. [CI] Run CI on maintenance branches (aramis-lab#1145)

    * run linter on maint branches
    
    * run unit tests on maint branches
    
    * run converter non regression tests on maint branches
    
    * run instantiation tests on maint branches
    NicolasGensollen authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    eaf6531 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e710a95 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3856557 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. [CI] Run CI on maintenance branches (aramis-lab#1149)

    * run linter on maint branches
    
    * run unit tests on maint branches
    
    * run converter non regression tests on maint branches
    
    * run instantiation tests on maint branches
    NicolasGensollen authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    f4c10f5 View commit details
    Browse the repository at this point in the history
  2. Release 0.8.1 (aramis-lab#1150)

    * update version number
    
    * update changelog
    NicolasGensollen authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    2333c12 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Configuration menu
    Copy the full SHA
    3fdfea6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e2ce719 View commit details
    Browse the repository at this point in the history
  3. [MAINT] Move bids version constant definition to bids module (aramis-…

    …lab#1153)
    
    * move bids version definition
    
    * update unit tests
    NicolasGensollen authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    cfa5874 View commit details
    Browse the repository at this point in the history
  4. [MAINT] Update OASIS website URL (aramis-lab#1155)

    * update OASIS website URL
    
    * Apply suggestions from code review
    NicolasGensollen authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a61c110 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    232d335 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Configuration menu
    Copy the full SHA
    31543c2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a317e11 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    374794e View commit details
    Browse the repository at this point in the history
  4. [FIX] Fix wrong preprocessing sequence in adni-to-bids FDG PET Uniform (

    aramis-lab#1159)
    
    * Wrong Processed sequence --> Results: Impossible to make bids of FDG PET Uniform (does not find it)
    
    * Linter exception
    
    * Linter word-list exception update
    
    * Update clinica/iotools/converters/adni_to_bids/adni_modalities/adni_fdg_pet.py
    
    Co-authored-by: Gensollen <[email protected]>
    
    * Update pyproject.toml
    
    Co-authored-by: Gensollen <[email protected]>
    
    * Update clinica/iotools/converters/adni_to_bids/adni_modalities/adni_fdg_pet.py
    
    Co-authored-by: Gensollen <[email protected]>
    
    * Update clinica/iotools/converters/adni_to_bids/adni_modalities/adni_fdg_pet.py
    
    * try using a text file for ignoring words
    
    * remove useless codespell:ignore
    
    * sort ignore words
    
    ---------
    
    Co-authored-by: Gensollen <[email protected]>
    HuguesRoy and NicolasGensollen authored Apr 26, 2024
    Configuration menu
    Copy the full SHA
    914fd77 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    06d5c64 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Configuration menu
    Copy the full SHA
    cd37d6f View commit details
    Browse the repository at this point in the history
  2. Review PR1119

    AliceJoubert committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    61a5e97 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fcdc015 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Configuration menu
    Copy the full SHA
    7def9cc View commit details
    Browse the repository at this point in the history