Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unusable views when Javascript is disabled #3804

Closed
nilmerg opened this issue May 28, 2019 · 0 comments
Closed

Unusable views when Javascript is disabled #3804

nilmerg opened this issue May 28, 2019 · 0 comments
Labels
area/navigation Affects the navigation bug Something isn't working

Comments

@nilmerg
Copy link
Member

nilmerg commented May 28, 2019

Describe the bug

Some views contain clickable elements which only have an effect when Javascript is enabled. Prime examples: Tactical overview, Announcement listing, Event overview

To Reproduce

Disable Javascript.

Expected behavior

I can:

  • See the 666 hosts that are on fire (tactical overview)
  • Edit an announcement
  • See an event's detail view

Additional context

That's due to the fact that these views don't provide any links for their row actions. They hardcode the href attribute on their tr's which is normally only controlled by Javascript. The same applies to some modules. (e.g. x509)
@nilmerg nilmerg added bug Something isn't working area/navigation Affects the navigation labels May 28, 2019
@nilmerg nilmerg mentioned this issue Jun 4, 2019
Closed
nilmerg added a commit that referenced this issue Jul 4, 2019
@nilmerg
tatical/index: Use an ul for the legends and render real links
1aca142 
refs #2529
refs #3804
@nilmerg nilmerg closed this as completed May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/navigation Affects the navigation bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nilmerg