Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main layout is broken without JS #3629

Closed
Thomas-Gelf opened this issue Nov 19, 2018 · 6 comments · Fixed by #3789
Closed

Main layout is broken without JS #3629

Thomas-Gelf opened this issue Nov 19, 2018 · 6 comments · Fixed by #3789
Assignees
Labels
bug Something isn't working

Comments

@Thomas-Gelf
Copy link
Contributor

Expected Behavior

Basic functionality should be available without JS, page should look good.

Current Behavior

It looks ugly, we broke this with v2.5

Steps to Reproduce (for bugs)

Disable JavaScript, load the page

@lippserd lippserd added this to the 2.6.2 milestone Nov 20, 2018
@lippserd lippserd added the bug Something isn't working label Nov 20, 2018
@lippserd lippserd modified the milestones: 2.6.2, 2.7.0 Nov 20, 2018
@lippserd lippserd reopened this Nov 20, 2018
@lippserd
Copy link
Member

Fix broke announcements.

flourish86 added a commit that referenced this issue May 21, 2019
@theFeu
Copy link
Contributor

theFeu commented May 22, 2019

I noticed, that in the detail views there is very little space between the tabs and the content in the controls div. With JS enabled there is a div with the class 'tabs-spacer'.

theFeu pushed a commit that referenced this issue May 22, 2019
@theFeu
Copy link
Contributor

theFeu commented May 22, 2019

Without JS the dropdown is also without functionality:

uselessbutton

What are we going to do about that?
I would suggest just putting the "Add To Dashboard" and "Add To Menu" into the tab bar itself.
It would probably be possible to simulate a dropdown - then again, since without JS it's single-col only anway, we should have the space to just add tabs :)

@theFeu
Copy link
Contributor

theFeu commented May 24, 2019

Todo here:

  • announcements break the tab bar
  • when trying to close an announcement things break as well
  • print to pdf doesn't exactly work either
  • 'monitoring-statusbar' in the footer is too wide
  • clicking on an event in the event history doesn't work

@theFeu
Copy link
Contributor

theFeu commented Jun 4, 2019

Layout problems will be fixed with #3810

still consisting issues:

@nilmerg
Copy link
Member

nilmerg commented Jun 4, 2019

  • clicking on an event in the event history doesn't work

Is covered by #3804.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants