Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid fixed positioning in main layout #3810

Closed
flourish86 opened this issue May 29, 2019 · 1 comment · Fixed by #3904
Closed

Avoid fixed positioning in main layout #3810

flourish86 opened this issue May 29, 2019 · 1 comment · Fixed by #3904
Assignees
@nilmerg
Labels
area/ui Affects the user interface enhancement New feature or improvement
Milestone
2.8.0

Comments

@flourish86
Copy link
Contributor

Problem

Fixed positioning requires a lot of js for layouting basic elements and therefore makes it unstable.

Solution

Use flexbox for main layout

Considerations

Different layout behavior for js and no-js, see WordPress Admin interface.
@flourish86 flourish86 added the area/ui Affects the user interface label May 29, 2019
@flourish86 flourish86 added this to the 2.7.0 milestone May 29, 2019
@theFeu theFeu mentioned this issue May 29, 2019
Open
flourish86 added a commit that referenced this issue May 29, 2019
@flourish86
CSS: Avoid fixed positioning
9f0c6aa 
refs #3810
flourish86 added a commit that referenced this issue May 29, 2019
@flourish86
CSS: Remove z-index from base layout elements
e975f59 
refs #3810
flourish86 added a commit that referenced this issue May 29, 2019
@flourish86
Body: Restructure markup for column layout
3bef086 
refs #3810
flourish86 added a commit that referenced this issue May 29, 2019
@flourish86
CSS: Layout main container with flex-box
69d1137 
refs #3810
flourish86 added a commit that referenced this issue May 29, 2019
@flourish86
CSS: Avoid fixed positioning for status bar
7e31eb9 
refs #3810
@nilmerg nilmerg added the enhancement New feature or improvement label Jun 4, 2019
This was referenced Jun 4, 2019
Closed
Closed
flourish86 added a commit that referenced this issue Jun 17, 2019
@flourish86
WIP JS: Fix container pos on auto reload
7fe15aa 
refs #3810
@nilmerg nilmerg modified the milestones: 2.7.0, 2.8.0 Jul 8, 2019
@nilmerg
Copy link
Member

nilmerg commented Jul 8, 2019

Postponed for v2.8 😭

@nilmerg nilmerg mentioned this issue Jul 8, 2019
Open
flourish86 added a commit that referenced this issue Aug 6, 2019
@flourish86
CSS: Prevent tabs from line-break
e885171 
refs #3810
flourish86 added a commit that referenced this issue Aug 6, 2019
@flourish86
CSS: Compensate .tabs-spacer
fc0b423 
refs #3810
flourish86 added a commit that referenced this issue Aug 6, 2019
@flourish86
CSS: Prevent tabs from line-break
1b3e4c6 
refs #3810
refs #3815
flourish86 added a commit that referenced this issue Aug 6, 2019
@flourish86
CSS: Compensate .tabs-spacer
4d3a83c 
refs #3810
refs #3815
flourish86 added a commit that referenced this issue Nov 13, 2019
@flourish86
CSS: Prevent tabs from line-break
f2c7975 
refs #3810
refs #3815
flourish86 added a commit that referenced this issue Nov 13, 2019
@flourish86
CSS: Compensate .tabs-spacer
a6a24e5 
refs #3810
refs #3815
lippserd pushed a commit that referenced this issue Dec 3, 2019
@flourish86 @lippserd
CSS: Prevent tabs from line-break
513db77 
refs #3810
refs #3815
lippserd pushed a commit that referenced this issue Dec 3, 2019
@flourish86 @lippserd
CSS: Compensate .tabs-spacer
03cc6a8 
refs #3810
refs #3815
lippserd pushed a commit that referenced this issue Dec 5, 2019
@flourish86 @lippserd
CSS: Prevent tabs from line-break
11ed2ae 
refs #3810
refs #3815
lippserd pushed a commit that referenced this issue Dec 5, 2019
@flourish86 @lippserd
CSS: Compensate .tabs-spacer
36e11c5 
refs #3810
refs #3815
@nilmerg nilmerg self-assigned this Dec 5, 2019
nilmerg pushed a commit that referenced this issue Dec 6, 2019
@flourish86 @nilmerg
CSS: Prevent tabs from line-break
59d063c 
refs #3810
refs #3815
nilmerg pushed a commit that referenced this issue Dec 6, 2019
@flourish86 @nilmerg
CSS: Compensate .tabs-spacer
03e73fc 
refs #3810
refs #3815
@flourish86 flourish86 mentioned this issue Dec 6, 2019
Merged
nilmerg pushed a commit that referenced this issue Dec 6, 2019
@flourish86 @nilmerg
CSS: Prevent tabs from line-break
433467a 
refs #3810
refs #3815
nilmerg pushed a commit that referenced this issue Dec 6, 2019
@flourish86 @nilmerg
CSS: Compensate .tabs-spacer
4f96685 
refs #3810
refs #3815
nilmerg pushed a commit that referenced this issue Dec 6, 2019
@flourish86 @nilmerg
CSS: Prevent tabs from line-break
eb104c3 
refs #3810
refs #3815
nilmerg pushed a commit that referenced this issue Dec 6, 2019
@flourish86 @nilmerg
CSS: Compensate .tabs-spacer
88db9c8 
refs #3810
refs #3815
@nilmerg nilmerg modified the milestones: 2.8.0-rc1, 2.8.0 May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nilmerg nilmerg

Labels
area/ui Affects the user interface enhancement New feature or improvement
Projects
None yet
Milestone
2.8.0
Development

Successfully merging a pull request may close this issue.

Rework layout with flexbox Icinga/icingaweb2
3 participants
@flourish86 @nilmerg @theFeu