Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix main layout for use without js #3789

Merged
merged 6 commits into from
Apr 15, 2020
Merged

Fix main layout for use without js #3789

merged 6 commits into from
Apr 15, 2020

Conversation

flourish86
Copy link
Contributor

@flourish86 flourish86 commented May 21, 2019 •
edited by nilmerg
Loading

fixes #3629

@flourish86 flourish86 added bug Something isn't working area/ui Affects the user interface labels May 21, 2019
nilmerg
nilmerg requested changes May 22, 2019
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Otherwise it looks good.

modules/monitoring/public/css/module.less Outdated Show resolved Hide resolved
public/js/icinga/ui.js Outdated Show resolved Hide resolved
@nilmerg
Copy link
Member

nilmerg commented May 23, 2019

Also, seems to still have problems with announcements:

Expected:
announcements-js

Actual:
announcements-no-js

Rebase with master once #3792 is merged to get multiple announcements working.

@flourish86 flourish86 force-pushed the bugfix/main-layout-is-broken-without-js-3629 branch from 9a5b034 to 228f998 Compare May 23, 2019 11:21
@flourish86
Copy link
Contributor Author

Just for the protocol. There are better solutions for a js-less ui.

Since we run into problems with the fixed tabs all the time, maybe a position: fixed-less layout would be the better option in the long run.

See how WordPress has done it with their backend. This is much more stable and less prone to errors and oddities.

Screen Recording 2019-05-23 at 15 04 55 2019-05-23 15_06_49

@flourish86 flourish86 force-pushed the bugfix/main-layout-is-broken-without-js-3629 branch from 981591f to fc982c2 Compare May 23, 2019 14:21
@nilmerg nilmerg self-requested a review April 8, 2020 14:53
@nilmerg nilmerg force-pushed the bugfix/main-layout-is-broken-without-js-3629 branch from fc982c2 to b85c706 Compare April 15, 2020 07:49
@nilmerg nilmerg added this to the 2.8.0 milestone Apr 15, 2020
@nilmerg nilmerg removed the request for review from lippserd April 15, 2020 08:12
@nilmerg nilmerg merged commit d287e3f into master Apr 15, 2020
@nilmerg nilmerg deleted the bugfix/main-layout-is-broken-without-js-3629 branch April 15, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

Assignees
No one assigned
Labels
area/ui Affects the user interface bug Something isn't working
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

Main layout is broken without JS
2 participants
@flourish86 @nilmerg