Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

igxDropDown feature #984

Closed
8 tasks done
bazal4o opened this issue Apr 13, 2018 · 1 comment
Closed
8 tasks done

igxDropDown feature #984

bazal4o opened this issue Apr 13, 2018 · 1 comment
Assignees
@dafo @IvayloG @wnvko @desig9stein
Labels
dropdown research ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@bazal4o
Copy link
Contributor

bazal4o commented Apr 13, 2018 •
edited by wnvko
Loading

Research
@SlavUI SlavUI changed the title Dropdown research and initial spec igxDropdown feature Apr 13, 2018
@SlavUI SlavUI changed the title igxDropdown feature igxDropDown feature Apr 13, 2018
wnvko added a commit that referenced this issue Apr 19, 2018
@wnvko
feat(IgxDropDown): Proof of concept, Closes #984
7b89766
dafo added a commit that referenced this issue Apr 23, 2018
@dafo
feat(dropdown): Adding disabled option #984
0134477
wnvko added a commit that referenced this issue Apr 23, 2018
@wnvko
Merge pull request #1109 from IgniteUI/AMarinov/disabled
c3a7264 
feat(dropdown): Adding disabled option #984
dafo added a commit that referenced this issue Apr 24, 2018
@dafo
chore(dropdown): Key Up is not focusing disabled items #984
b825279
dafo added a commit that referenced this issue Apr 24, 2018
@dafo
chore(dropdown): Improving the disabled logic #984
a6f0d11
dafo added a commit that referenced this issue Apr 24, 2018
@dafo
chore(dropdown): Implement "End" key logic #984
203e31b
dafo added a commit that referenced this issue Apr 24, 2018
@dafo
chore(dropdown): Adding "Home" key functionality/"Up" key skipping he…
914123b 
…aders #984
dafo added a commit that referenced this issue Apr 24, 2018
@dafo
chore(dropdown): Adding "aria-selected" attribute to the items #984
c9375de
@bazal4o bazal4o added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Apr 26, 2018
@desig9stein
Copy link
Contributor

desig9stein commented Apr 26, 2018 •
edited
Loading

Visual design:
components-menus-specs1-desktop

components-menus-specs4

dafo added a commit that referenced this issue Apr 30, 2018
@dafo
chore(dropdown): Adding .spec file for the IgxDropDown component #984
872c111
dafo added a commit that referenced this issue Apr 30, 2018
@dafo
chore(dropdown): Adding test scenarios #984
ddb9483
dafo added a commit that referenced this issue May 3, 2018
@dafo
chore(dropdown): Throw error when setSelecteditem() is out of range #984
973b360
dafo added a commit that referenced this issue May 3, 2018
@dafo
chore(dropdown): Removing throw errors #984
6f6a6aa
dafo added a commit that referenced this issue May 3, 2018
@dafo
chore(dropdown): Editing the spec file #984
324db30
ViktorSlavov added a commit that referenced this issue May 3, 2018
@ViktorSlavov
test(igx-drop-down): refactor initial test, #984
d3f0d18
dafo added a commit that referenced this issue May 3, 2018
@dafo
chore(dropdown): Adding test scenario #984
800394b
ViktorSlavov added a commit that referenced this issue May 3, 2018
@ViktorSlavov
test(igx-drop-down): add test for keynav and selection, scroll WIP, #984
d3ab9d6
ViktorSlavov added a commit that referenced this issue May 3, 2018
@ViktorSlavov
test(igx-drop-down): add test for keyboard selection, #984
8aadacb
ViktorSlavov added a commit that referenced this issue May 3, 2018
@ViktorSlavov
style(igx-drop-down): all comments start with space, tslint, #984
08195b5
ViktorSlavov added a commit that referenced this issue May 4, 2018
@ViktorSlavov
test(igx-drop-down): add scroll test, #984
707e02c
dafo added a commit that referenced this issue May 8, 2018
@dafo
chore(dropdown): Adding test for the id property #984
82f09eb
dafo added a commit that referenced this issue May 9, 2018
@dafo
chore(dropdown): Adding test for focusing disabled items #984
63910d4
dafo added a commit that referenced this issue May 9, 2018
@dafo
chore(dropdown): test - clicking disabled item not moving focus #984
f03a145
dafo added a commit that referenced this issue May 9, 2018
@dafo
chore(dropdown): fixing tests #984
8339f26
dafo added a commit that referenced this issue May 9, 2018
@dafo
chore(dropdown): reverting test entry point #984
4db72ad
dafo added a commit that referenced this issue May 10, 2018
@dafo
chore(dropdown): Remove the 'get' from setTabIndex #984
b5df0f8
@IvayloG IvayloG mentioned this issue May 10, 2018
Closed
dafo added a commit that referenced this issue May 10, 2018
@dafo
chore(dropdown): Fixing tests #984
cc0eb4b
This was referenced May 10, 2018
Closed
Merged
dafo added a commit that referenced this issue May 10, 2018
@dafo
chore(dropdown): Adding tests #984
1b7cafd
dafo added a commit that referenced this issue May 10, 2018
@dafo
chore(dropdown): Adding tests #984
14ebd35
@wnvko wnvko mentioned this issue May 10, 2018
Closed
wnvko added a commit that referenced this issue May 10, 2018
@wnvko
fix(igxDropDown): fix ts-lint issue, closes #984
49ffa48
wnvko added a commit that referenced this issue May 11, 2018
@wnvko
fix(igxDropDown): code refactoring, closes #984
9bb0b1d
wnvko added a commit that referenced this issue May 11, 2018
@wnvko
fix(igxDropDown): fox home and end navigation, closes #984
0227151
wnvko added a commit that referenced this issue May 14, 2018
@wnvko
fix(igxDropDown): add missing quotes in package-lock.json, closes #984
5df694a
wnvko added a commit that referenced this issue May 15, 2018
@wnvko
fix(igxDropDown): fix toggle directive's onOpening call, closes #984
2766561
wnvko added a commit that referenced this issue May 15, 2018
@wnvko
test(igxDropDown): add unit tests, closes #984
2e63948
wnvko added a commit that referenced this issue May 15, 2018
@wnvko
test(igxDropDown): fix failing test, closes #984
4346c44
dafo added a commit that referenced this issue May 17, 2018
@dafo
test(dropdown): Verifying the dropdown is collapsed #984
a37fe1f
dafo added a commit that referenced this issue May 18, 2018
@dafo
test(dropdown): Add verification for disabled items #984
5f61524
dafo added a commit that referenced this issue May 18, 2018
@dafo
chore(dropdown): Removing a fit #984
0eca58d
ViktorSlavov added a commit that referenced this issue May 18, 2018
@ViktorSlavov
test(igx-drop-down): adjust tests to account for toggle animation, #984
4f7b669
wnvko added a commit that referenced this issue May 25, 2018
@wnvko
fix(igxDropDown): fix the name of IgxDropDownTestEmptyList, closes #984
9a43585
@wnvko wnvko mentioned this issue May 31, 2018
Merged
@wnvko wnvko added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dafo dafo

@IvayloG IvayloG

@wnvko wnvko

@desig9stein desig9stein

Labels
dropdown research ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dafo @bazal4o @IvayloG @wnvko @desig9stein