feat: Add topic for igx-drop-down component. #402

IvayloG · 2018-05-10T07:01:27Z

closes #401
Related to: IgniteUI/igniteui-angular#984

bazal4o · 2018-05-10T12:10:36Z

en/components/drop_down.md

+...
+    @ViewChild(IgxDropDownComponent) public igxDropDown: IgxDropDownComponent;
+
+    public items: any[] = [


Let's create one more group/header

bazal4o

I have single comment

wnvko · 2018-05-14T12:02:54Z

en/components/drop_down.md

+
+| Name | Cancelable | Description | Parameters
+| :--- | :--- | :--- | :--- |
+| `onSelection` | false | Emitted when item selection is changing, before the selection completes. | `{ oldSelection: string, newSelection: string, event?: Event }` |


The parameters here are of ISelectionEventArgs type.

wnvko · 2018-05-14T12:03:47Z

en/components/drop_down.md

+| Name | Type | Description |
+| :--- | :--- | :--- |
+| `selectedItem` | `number` | Gets the selected item. |
+| `items` | `QueryList of IgxDropDownItemComponent` | Gets all of the items but headers. |


Items, as Headers, are of IgxDropDownItemComponent[] type.

ig-ealbert

@yoshimis I left comments inline.
I will email about problems with the TM / SDLXLIFF file.
Additionally, there were changes made to the toggle.md file, which should be addressed here too, so we keep everything in sync.

ig-ealbert · 2018-05-14T14:25:40Z

jp/components/drop_down.md

+title: Drop Down コンポーネント
+_description: Ignite UI for Angular Drop Down は、単一項目の選択が可能なグループ化された項目のリストにスクロールを表示します。
+_keywords: Ignite UI for Angular, UI controls, Angular widgets, web widgets, UI widgets, Angular, Native Angular Components Suite, Native Angular Controls, Native Angular Components Library, Angular Drop Down components, Angular Drop Down controls
+---


@yoshimis There needs to be an extra metadata field added to all new Japanese files.
_language: ja

ig-ealbert · 2018-05-14T14:25:53Z

jp/components/drop_down.md

+---
+title: Drop Down コンポーネント
+_description: Ignite UI for Angular Drop Down は、単一項目の選択が可能なグループ化された項目のリストにスクロールを表示します。
+_keywords: Ignite UI for Angular, UI controls, Angular widgets, web widgets, UI widgets, Angular, Native Angular Components Suite, Native Angular Controls, Native Angular Components Library, Angular Drop Down components, Angular Drop Down controls


This needs to be translated.

ig-ealbert · 2018-05-14T14:29:15Z

jp/components/drop_down.md

+    <iframe id="dropdown-sample-3-iframe" src='{environment:demosBaseUrl}/dropdown-sample-3' width="100%" height="100%" seamless frameBorder="0" onload="onSampleIframeContentLoaded(this);"></iframe>
+</div>
+<div>
+<button data-localize="stackblitz" class="stackblitz-btn" data-iframe-id="dropdown-sample-3-iframe" data-demos-base-url="{environment:demosBaseUrl}">stackblitz で開く</button>


In all of the other topics, we've been casing this as StackBlitz.

Replaced stackblitz with StackBlitz.

I just noticed that stackblitz appears all capital in production. So case does not matter.

ig-ealbert · 2018-05-14T14:31:52Z

jp/components/drop_down.md

+})
+export class AppModule {}
+```　
+構成の後、すべてのオプションを  [**IgxDropDownComponent**](https://www.infragistics.com/products/ignite-ui-angular/angular/components/drop_down.html) コンポーネントに表示します。ドロップダウンは、ドロップダウン項目として複数のオプションを含みます。


Please update the URL. It can actually be changed to a relative URL like drop_down.html. I forget if they went and changed all of them to .html or .md, so please reference the other topics to see how it's done. Otherwise, this will always go to the EN production site. Even if you just change it to the JP site, then it won't work on staging.

Updated '.md'.

ig-ealbert · 2018-05-14T14:32:37Z

jp/components/drop_down.md

+
+<div class="divider--half"></div>
+
+選択済みの項目をあらかじめ定義する場合、[**IgxDropDownComponent**](https://www.infragistics.com/products/ignite-ui-angular/angular/components/drop_down.html) **igx-drop-down**  `onOpening` イベントを処理します。


Please update the URL here too. Additionally, there is a の missing between the link and the control name.

Updated URL and adding の.

ig-ealbert · 2018-05-14T14:37:13Z

jp/components/drop_down.md

+#### ゲッター
+以下のゲッターは **igx-drop-down** コンポーネントで利用できます。
+
+| 名前 | タイプ | 説明 |


Same "type" feedback.

ig-ealbert · 2018-05-14T14:37:31Z

jp/components/drop_down.md

+| 名前 | タイプ | 説明 |
+| :--- | :--- | :--- |
+| `selectedItem` | `number` | 選択項目を取得します。|
+| `items` | `QueryList of IgxDropDownItemComponent` | Gヘッダー以外のすべての項目を取得します。 |


Extra G here - please remove.

ig-ealbert · 2018-05-14T14:38:00Z

jp/components/drop_down.md

+#### 入力
+以下の入力は **igx-drop-down-item** コンポーネントで利用できます。
+
+| 名前 | タイプ | 説明 |


Same type feedback.

Replaced タイプ with 型.

ig-ealbert · 2018-05-14T14:38:32Z

jp/components/drop_down.md

+| `isFocused` | ブール値| 指定した項目がフォーカスされるかどうかを定義します。|
+
+#### ゲッター
+以下のゲッターは **igx-drop-down** コンポーネントで利用できます。


This should be **igx-drop-down-item**.

ig-ealbert · 2018-05-14T14:38:41Z

jp/components/drop_down.md

+#### ゲッター
+以下のゲッターは **igx-drop-down** コンポーネントで利用できます。
+
+| 名前 | タイプ | 説明 |


Same type feedback.

Replaced タイプ with 型.

ig-ealbert · 2018-05-15T13:54:27Z

@yoshimis Can you please make the changes to the toggle.md file?

IvayloG added 2 commits May 10, 2018 09:55

feat: Add topic for igx-drop-down component.

aca5869

chore: Remove igxRipple

e950cbe

IvayloG requested review from bazal4o and dafo May 10, 2018 07:20

chore: Items collection does not return headers

f396665

IvayloG assigned bazal4o May 10, 2018

IvayloG added the status: awaiting-test label May 10, 2018

chore: Clarify inline explanations.

d564cd3

dafo previously approved these changes May 10, 2018

View reviewed changes

bazal4o added status: verified and removed status: awaiting-test labels May 10, 2018

fix: drop_down nav renaming.

f2d122d

bazal4o added status: in-test and removed status: verified labels May 10, 2018

IvayloG dismissed dafo’s stale review via f2d122d May 10, 2018 11:58

bazal4o reviewed May 10, 2018

View reviewed changes

bazal4o suggested changes May 10, 2018

View reviewed changes

IvayloG added 2 commits May 10, 2018 16:37

feat: Add more countries.

e15f71d

fix: dropdown containers coliding with btns

c6711a1

IvayloG added the status: pending-localization label May 10, 2018

bazal4o previously approved these changes May 10, 2018

View reviewed changes

bazal4o added status: verified and removed status: in-test labels May 10, 2018

yoshimis removed the status: pending-localization label May 14, 2018

Translated drop_down.md.

0dde9a1

yoshimis dismissed bazal4o’s stale review via 0dde9a1 May 14, 2018 05:27

wnvko reviewed May 14, 2018

View reviewed changes

chore(igxDropDown): update toggle.md with the new events

12a28ca

ig-ealbert suggested changes May 14, 2018

View reviewed changes

Updated according to Liz's comments.

9665126

yoshimis added 2 commits May 15, 2018 13:33

Adding a missing character and remove an unncessary character.

5c5783a

Adding "-item" to "**igx-drop-down-item**" .

9f56227

yoshimis added the status: localized label May 15, 2018

Translated new strings.

e08b26a

ig-ealbert previously approved these changes May 16, 2018

View reviewed changes

fix: Update the API.

170363f

IvayloG dismissed ig-ealbert’s stale review via 170363f May 17, 2018 05:59

IvayloG added status: pending-localization and removed status: localized labels May 17, 2018

Translated API changes.

4499daa

yoshimis added status: localized and removed status: pending-localization labels May 17, 2018

ig-ealbert approved these changes May 21, 2018

View reviewed changes

bazal4o merged commit 0977c43 into master Jun 1, 2018

bazal4o deleted the IGanchev/add-dropdown-component branch June 1, 2018 08:13

bazal4o restored the IGanchev/add-dropdown-component branch June 1, 2018 12:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add topic for igx-drop-down component. #402

feat: Add topic for igx-drop-down component. #402

IvayloG commented May 10, 2018

bazal4o May 10, 2018

bazal4o left a comment

wnvko May 14, 2018

wnvko May 14, 2018

ig-ealbert left a comment

ig-ealbert May 14, 2018

yoshimis May 15, 2018

ig-ealbert May 14, 2018

yoshimis May 15, 2018

ig-ealbert May 14, 2018

yoshimis May 15, 2018

yoshimis May 15, 2018

ig-ealbert May 14, 2018

yoshimis May 15, 2018

ig-ealbert May 14, 2018

yoshimis May 15, 2018

ig-ealbert May 14, 2018

ig-ealbert May 14, 2018

yoshimis May 15, 2018

ig-ealbert May 14, 2018

yoshimis May 15, 2018

ig-ealbert May 14, 2018

yoshimis May 15, 2018

ig-ealbert May 14, 2018

yoshimis May 15, 2018

ig-ealbert commented May 15, 2018


		<div class="divider--half"></div>

		選択済みの項目をあらかじめ定義する場合、[IgxDropDownComponent](https://www.infragistics.com/products/ignite-ui-angular/angular/components/drop_down.html) igx-drop-down `onOpening` イベントを処理します。

feat: Add topic for igx-drop-down component. #402

feat: Add topic for igx-drop-down component. #402

Conversation

IvayloG commented May 10, 2018

Choose a reason for hiding this comment

bazal4o left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ig-ealbert left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ig-ealbert commented May 15, 2018