refactor(viewer.js): Add errorinterceptor argument to propagate error to the top level app #85
Conversation
|
@hackermd I do not seem to have permissions to add reviewers to this PR. Please know it's ready for your review. Thanks! |
|
@hackermd I have addressed the requested changes. Please let me know if this can be merged? Thank you. |
There was a problem hiding this comment.
Thanks @GitanjaliChhetri. The changes look good. However, the yarn test command currently fails for me. The error report includes a lot of linting errors that were discovered by yarn lint.
Unfortunately, the "unit tests" workflow doesn't automatically get tricked for the pull request. I somehow can't add it as a required status check. cc @fedorov
Until this issue is resolved, the checks need to be run manually locally.
|
@GitanjaliChhetri @fedorov got the status checks working. |
GitanjaliChhetri
force-pushed
the
addErrorInterceptor
branch
from
5bf7586
to
3ecbe48
Compare
|
@hackermd can you please re-review? Per @GitanjaliChhetri, all of your concerns should now be addressed. |
igoroctaviano
changed the title
…ckages (ImagingDataCommons#113)" This reverts commit 2834944.
…py-viewer into addErrorInterceptor
…other packages (ImagingDataCommons#113)"" This reverts commit f5abca9.
Errors thrown in viewer.js can now be propagated to the Slim Viewer App.
Changes needed for ImagingDataCommons/slim#134