-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle errors globally with Error Middleware and React Error Boundary #134
Handle errors globally with Error Middleware and React Error Boundary #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments. Please prioritize the removal of all formatting changes so we have a clearer pull request to review.
Thank you in advance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GitanjaliChhetri code LGTM. Feel free to assign it to @hackermd for final review/approval.
@hackermd I am unable to add you as one of the reviewers. Please know this PR is ready for your review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GitanjaliChhetri, thanks so much for this great work!
I only have a few comments regarding coding style and questions regarding naming things.
@hackermd I have addressed the requested changes. Please let me know if this can be merged? Thank you. |
@hackermd if you could let us know when you might have time to look into this, it would be helpful! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GitanjaliChhetri it's an elegant implementation. Please address the coding style issues and make sure the automated tests pass. Then we should be ready to merge.
@hackermd comments addressed. Can you please re-review? also, looks like the deploy gh-pages are not working. I think its because of action permissions. https://stackoverflow.com/questions/72851548/permission-denied-to-github-actionsbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @igoroctaviano!
Not sure why this is happening. The settings are correct and it should work. Maybe a quirk related to the moving of the repository to the ImagingDataCommons organization. Could this be an issue with a global org-wide setting? |
Summary of the PR: