Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILD: pin imjoy-jupyterlab-extension for optional lab to 0.1.13 #695

Merged
merged 1 commit into from
Nov 28, 2023
Merged

BUILD: pin imjoy-jupyterlab-extension for optional lab to 0.1.13 #695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ all = [
"aiohttp <4.0"
]
lab = [
"imjoy-jupyterlab-extension >=0.1.13",
"imjoy-jupyterlab-extension ==0.1.13",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason to pin it to the old version? I thought we need that for the new jupyterlab. What did I missed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed to follow this:
94fee57

Which references this issue that I have not checked myself:
imjoy-team/imjoy-jupyterlab-extension#4

"imjoy-elfinder[jupyter]",
"aiohttp <4.0"
]
Expand Down