Implement dpnp.nan_to_num()
#1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
Aug 5, 2024
antonwolfy
reviewed
Aug 6, 2024
antonwolfy
reviewed
Aug 6, 2024
antonwolfy
approved these changes
Aug 7, 2024
github-actions bot
added a commit
that referenced
this pull request
Aug 9, 2024
* Implement dpnp.nan_to_num() * Update cupy tests for nan_to_num() * Add dpnp tests * Skip test_nan_to_num_scalar_nan * Applied review comments * Add more tests for nan_to_num() * Improve perfomance using out empty_like array * Add checks for nan, posinf, neginf args * Add type check for nan, posinf and neginf * Update tests * Add support boolean type cb31797
antonwolfy
pushed a commit
that referenced
this pull request
Aug 9, 2024
* Implement dpnp.nan_to_num() * Update cupy tests for nan_to_num() * Add dpnp tests * Skip test_nan_to_num_scalar_nan * Applied review comments * Add more tests for nan_to_num() * Improve perfomance using out empty_like array * Add checks for nan, posinf, neginf args * Add type check for nan, posinf and neginf * Update tests * Add support boolean type
antonwolfy
added a commit
that referenced
this pull request
Aug 12, 2024
* Leverage on dpctl shape.setter for any input * Mute false-positive pylint issue * Remove disable=invalid-unary-operand-type since resolved with pylint 3.2.6 * Implement `dpnp.nan_to_num()` (#1966) * Implement dpnp.nan_to_num() * Update cupy tests for nan_to_num() * Add dpnp tests * Skip test_nan_to_num_scalar_nan * Applied review comments * Add more tests for nan_to_num() * Improve perfomance using out empty_like array * Add checks for nan, posinf, neginf args * Add type check for nan, posinf and neginf * Update tests * Add support boolean type * Apply suggestions from code review Co-authored-by: vtavana <[email protected]> * Corrected a link in docstring * Updated wring indention --------- Co-authored-by: vlad-perevezentsev <[email protected]> Co-authored-by: vtavana <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Aug 12, 2024
* Leverage on dpctl shape.setter for any input * Mute false-positive pylint issue * Remove disable=invalid-unary-operand-type since resolved with pylint 3.2.6 * Implement `dpnp.nan_to_num()` (#1966) * Implement dpnp.nan_to_num() * Update cupy tests for nan_to_num() * Add dpnp tests * Skip test_nan_to_num_scalar_nan * Applied review comments * Add more tests for nan_to_num() * Improve perfomance using out empty_like array * Add checks for nan, posinf, neginf args * Add type check for nan, posinf and neginf * Update tests * Add support boolean type * Apply suggestions from code review Co-authored-by: vtavana <[email protected]> * Corrected a link in docstring * Updated wring indention --------- Co-authored-by: vlad-perevezentsev <[email protected]> Co-authored-by: vtavana <[email protected]> 4a23239
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests implementing new math function
dpnp.nan_to_num()through dpnp functions likedpnp.isposinf(),dpnp.isneginf()dpnp.isnan()anddpnp.where(). Also added new tests covering cases not implemented in CuPy testsPerformance measurements on PVC
