Add FromSharedCBOR constraint to the EraTxOut
#2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
lehins
force-pushed
the
lehins/fixups-to-recent-restructure
branch
from
cfb88d0
to
8da3495
Compare
A more restricitve constraint with a redundant associated type family constraint causes GHC to generate code that goes into an infinite loop. This depicts iteslf in an OOM when compiled with `-O0` and non terminating computaton when compiled with optimizations. Here is the bug report on the GHC issue tracker: https://gitlab.haskell.org/ghc/ghc/-/issues/21973
lehins
force-pushed
the
lehins/fixups-to-recent-restructure
branch
from
8da3495
to
01a43be
Compare
|
Seems like this PR has discovered a bug in GHC: https://gitlab.haskell.org/ghc/ghc/-/issues/21973 A work around has been applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to not propagate this
FromSharedCBORconstraint all the way to consensus it should be as a superclass ofEraTxOut(before it was superclass ofShelleyBasedErasynonym, which was removed in #2901)