Minimize constraints to avoid ghc bug #2978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
approved these changes
Aug 16, 2022
…hc bug: * GHC bug: https://gitlab.haskell.org/ghc/ghc/-/issues/21973 * Minimized number of constraints in all modules where the bug was possible: * `Cardano.Ledger.Shelley.TxBody` * `Cardano.Ledger.Shelley.Tx` * `Cardano.Ledger.ShelleyMA.TxBody` * `Catrdano.Ledger.Alonzo.TxBody` * `Catrdano.Ledger.Alonzo.Tx` * `Catrdano.Ledger.Babbage.TxBody`
lehins
force-pushed
the
lehins/minimize-constraints-to-avoid-ghc-bug
branch
from
53d648c
to
651d325
Compare
|
Fixed that 😹 rdano and squashed into one commit with a better message. Will merge as soon as PR goes green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consensus tools tests stumbled upon the same GHC bug that was mentioned in this #2950 (comment)
I went through all of the sites where bug could potentially be triggered and removed this possibility by removing redundant constraints.
There are no semantic changes in this PR, just expansion of class instances' constraints to the minimal possible set, but only for those instances that can trigger the bug.