Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ouroborus-consensus serialization roundtrip test #4072

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Feb 12, 2024

Description

This change has been tested locally against ouroboros-consensus master a6e6707974d12fecd40650e6fb995d2058772d37 by pointing cabal to a local checkout of cardano-ledger at the tag cardano-ledger-shelley-1.9.0.0 with the same change.

Resolves #3740

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd marked this pull request as ready for review February 12, 2024 11:37
@aniketd aniketd force-pushed the aniketd/consensus-ouroborus-roundtrip-3740 branch from 32770ab to 6ff09be Compare February 12, 2024 11:47
@lehins lehins changed the title Fix ouroborus-consensus roundtrip Fix ouroborus-consensus serialization roundtrip test Feb 12, 2024
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice find.

Could you also open a ticket on the consensus repo, that will track re-enabling those roundtrip tests whenever they will be integrating new ledger

@lehins
Copy link
Collaborator

lehins commented Feb 12, 2024

Also looks like our golden tests need fixing, which is expected
(note on the consensus ticket that they'll have to do the same)

This example just needed an update.
@lehins lehins force-pushed the aniketd/consensus-ouroborus-roundtrip-3740 branch from 32e733e to c2a753a Compare February 13, 2024 13:35
@aniketd aniketd merged commit f8e203e into master Feb 13, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conway ledger state deserialize failure
2 participants