Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - Reenable roundtrip tests for cardano-ledger ledger state and extended ledger state for the next release #950

Closed
aniketd opened this issue Feb 12, 2024 · 1 comment · Fixed by #1032
Closed

[BUG] - Reenable roundtrip tests for cardano-ledger ledger state and extended ledger state for the next release #950

aniketd opened this issue Feb 12, 2024 · 1 comment · Fixed by #1032
Assignees
@dnadales
Labels
Conway Issues related to the Conway era

Comments

@aniketd
Copy link
Contributor

aniketd commented Feb 12, 2024 •
edited
Loading

Internal

Summary
IntersectMBO/cardano-ledger#4072 fixes IntersectMBO/cardano-ledger#3740 and so the mentioned failing roundtrip tests for ledger state and extended ledger state can be reenabled once we bump the dependency to cardano-ledger-shelley-test-1.3.0.2.

Note
This change also affects any related golden tests, so their expectations would almost most likely need to be updated.
@aniketd aniketd added the Conway Issues related to the Conway era label Feb 12, 2024
@dnadales
Copy link
Member

Thank you, Aniket! 🙌

@dnadales dnadales self-assigned this Feb 16, 2024
@dnadales dnadales mentioned this issue Apr 3, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 3, 2024
@dnadales
Consensus release for Node 8.10 (#1032)
2a4f737 
This PR also closes
#950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnadales dnadales

Labels
Conway Issues related to the Conway era
Projects
Consensus Team Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consensus release for Node 8.10 IntersectMBO/ouroboros-consensus
2 participants
@dnadales @aniketd