-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI 1.35.4-RC1 crashing with a --cddl-format error #4597
Comments
Not a bug! We have deprecated the intermediate tx body format so you can no longer create it, however it can still be read. Lets put a breaking change note in the Changelog. |
It is not a bug, but many 3rd party tooling are depending on this parameter that is removed and as such it is breaking their solution. Basically it should have skipped this parameter if provided by the 3rd party solution, instead of giving an error message. This would have been a much more elegant solution dealing with this issue. Now 3rd parties have to go over their code and remove it on basis of something they were not informed about. Jmho. |
Ok, we can adjust it so that it does not fail. |
thx @Jimbo4350, if the "dummy --cddl-format" flag is in for the next releases that would be perfect. so 3rd party tools have time to set a new node/cli min version in there tools and also remove the --cddl-flag from the calling commands. |
4617: Restore --cddl-format r=disassembler a=newhoggy as a hidden switch to avoid breaking 3rd party tooling. The restore switch has no effect Resolves #4597 Co-authored-by: John Ky <[email protected]>
4617: Restore --cddl-format r=disassembler a=newhoggy as a hidden switch to avoid breaking 3rd party tooling. The restore switch has no effect Resolves #4597 Co-authored-by: John Ky <[email protected]>
Using the
--cddl-format
flag with this revision in thetransaction build-raw
command causes an error:Invalid option '--cddl-format'
Also the two lines
are missing when checking the syntax with this revision like
cardano-cli transaction build-raw
if cddl-format is now the default and only format, the cli should still accept the flag for a while to change the calling in 3rd party tools.
The text was updated successfully, but these errors were encountered: