Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore --cddl-format #4617

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Nov 4, 2022

as a hidden switch to avoid breaking 3rd party tooling. The restore switch has no effect

Resolves #4597

@newhoggy newhoggy changed the title Restore --cddl-format as a hidden switch to avoid breaking 3rd party … Restore --cddl-format Nov 4, 2022
@newhoggy newhoggy marked this pull request as ready for review November 4, 2022 13:53
@newhoggy newhoggy force-pushed the newhoggy/restore-cddl-format-as-hidden-deprecated-option branch from bb00609 to 97ddcfa Compare November 4, 2022 13:56
…tooling. The restore switch has no effect

Add --cddl-format flag to tests to confirm backwards compatibility
@Jimbo4350 Jimbo4350 force-pushed the newhoggy/restore-cddl-format-as-hidden-deprecated-option branch from 97ddcfa to 97865a5 Compare November 4, 2022 15:35
@disassembler
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 5, 2022
4617: Restore --cddl-format r=disassembler a=newhoggy

 as a hidden switch to avoid breaking 3rd party tooling.  The restore switch has no effect

Resolves #4597

Co-authored-by: John Ky <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 5, 2022

Timed out.

@gitmachtl
Copy link
Contributor

Looks good, the transaction build/build-raw command is now working again without an error. We will update the tools to remove the --cddl-format calling flag once 1.35.4 is released to be ready for a full removal starting with 1.36.*

@disassembler
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 5, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 74a8529 into release/1.35 Nov 5, 2022
@iohk-bors iohk-bors bot deleted the newhoggy/restore-cddl-format-as-hidden-deprecated-option branch November 5, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants