Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Governance Action submission (edit) #362

Closed
MSzalowski opened this issue Mar 4, 2024 · 2 comments · Fixed by #391
Closed

Review Governance Action submission (edit) #362

MSzalowski opened this issue Mar 4, 2024 · 2 comments · Fixed by #391
Assignees
@Sworzen1 @pmbinapps
Labels
🖥 Frontend Frontend related
Milestone
Byron - GA Submit...

Comments

@MSzalowski
Copy link
Contributor

MSzalowski commented Mar 4, 2024 •
edited
Loading

Why

As a user, I want to be able to review my submission so that I can edit the provided information.

What

Create a screen that contains the Governance Action submission data with an easy-to-read form.

The screen should include an Edit submission button allowing you to go back with previously filled information and edit it.

Link to figma

How

Create a screen that contains the Governance Action submission data with an easy-to-read form.
Create Edit submission button that navigates back to form with an edit mode.
@MSzalowski MSzalowski mentioned this issue Mar 4, 2024
Closed
@MSzalowski MSzalowski added the 🖥 Frontend Frontend related label Mar 4, 2024
@Sworzen1 Sworzen1 self-assigned this Mar 5, 2024
Sworzen1 added a commit that referenced this issue Mar 6, 2024
@Sworzen1
[#362] add review submission page
192fb0a
@Sworzen1 Sworzen1 linked a pull request Mar 6, 2024 that will close this issue
feat/362-review-governance-action-submission-edit #391
Merged
5 tasks
@MSzalowski MSzalowski mentioned this issue Mar 6, 2024
Merged
5 tasks
Sworzen1 added a commit that referenced this issue Mar 6, 2024
@Sworzen1
[#362] dont show links when unavailable
865f431
Sworzen1 added a commit that referenced this issue Mar 6, 2024
@Sworzen1
[#362] add review submission page
4af59c9
Sworzen1 added a commit that referenced this issue Mar 6, 2024
@Sworzen1
[#362] dont show links when unavailable
a506680
Sworzen1 added a commit that referenced this issue Mar 6, 2024
@Sworzen1
[#362] fix display data only for one type of GA
0b8d47f
Sworzen1 added a commit that referenced this issue Mar 6, 2024
@Sworzen1
[#362] fix display data only for one type of GA
468ad44
@pmbinapps pmbinapps mentioned this issue Mar 7, 2024
Merged
pmbinapps pushed a commit that referenced this issue Mar 7, 2024
@Sworzen1 @pmbinapps
[#362] add review submission page
b08216d
pmbinapps pushed a commit that referenced this issue Mar 7, 2024
@Sworzen1 @pmbinapps
[#362] dont show links when unavailable
0f89f67
pmbinapps pushed a commit that referenced this issue Mar 7, 2024
@Sworzen1 @pmbinapps
[#362] fix display data only for one type of GA
f260468
@pmbinapps
Copy link

Visual Aspect:

OK Clear and organized submission display.
OK Properly labeled and arranged form.
OK Prominent "Edit submission" button.
OK Consistent design elements throughout.
OK Enhanced readability and aesthetics.

Functional Aspect:

OK Edit button navigates to form.

OK Smooth and intuitive navigation flow.

TODO later :Ability to save changes.

Image

@pmbinapps pmbinapps self-assigned this Mar 7, 2024
@pmbinapps
Copy link

Recheck (test-sanchonet):

Image

@pmbinapps pmbinapps mentioned this issue Mar 8, 2024
Merged
@MSzalowski MSzalowski mentioned this issue Mar 13, 2024
Merged
pmbinapps added a commit that referenced this issue Mar 13, 2024
@pmbinapps
Merge pull request #460 from IntersectMBO/test
f0f99c6 
staging: #351, #350, #320, #223, #317, #385, #358, #359, #151, #358, #360, #110, #379, #382, #361, #362, #446, #188, #377, #432, #364, #451, #433
MSzalowski pushed a commit that referenced this issue Mar 19, 2024
@pmbinapps @MSzalowski
Merge pull request #460 from IntersectMBO/test
fa67064 
staging: #351, #350, #320, #223, #317, #385, #358, #359, #151, #358, #360, #110, #379, #382, #361, #362, #446, #188, #377, #432, #364, #451, #433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sworzen1 Sworzen1

@pmbinapps pmbinapps

Labels
🖥 Frontend Frontend related
Projects
Govtool all
Status: Done
Milestone
Byron - GA Submitter - Review inputs ...
Development

Successfully merging a pull request may close this issue.

feat/362-review-governance-action-submission-edit IntersectMBO/govtool
3 participants
@MSzalowski @Sworzen1 @pmbinapps