[#239 #240 #338] DRep can become Sole Voter, Sole Voter can become DRep #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanJaroszczak
requested review from
MSzalowski,
Sworzen1 and
kickloop
as code owners
MSzalowski
requested changes
Feb 28, 2024
| const hashSubmitValue = hash ?? ""; | ||
| // Temporary solution. To modify later. | ||
| const urlSubmitValue = | ||
| !url || url === "" |
There was a problem hiding this comment.
!undefined === true, !null === true, !"" === true, !'' === true
Conclusion: OR operator here makes no sense in my opinion
Sworzen1
reviewed
Feb 28, 2024
| @@ -5,12 +5,13 @@ import { useCardano } from "@context"; | |||
| import { getDRepInfo } from "@services"; | |||
|
|
|||
| export const useGetDRepInfo = () => { | |||
There was a problem hiding this comment.
then change this on useGetVoterInfo connected with voter data
| @@ -112,7 +112,7 @@ export const en = { | |||
| registrationInProgress: | |||
| "The registration process is ongoing. This may take several minutes.", | |||
| retire: "Retire", | |||
| retireTitle: "You Have Retired as a Sole Voter", | |||
| wasSoleVoterTitle: "You Have Retired as a Sole Voter", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Checklist
related issues: #239 #240 #338