Restore en-/decoding compatibility for GetCurrentPParams
#95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amesgen
changed the title
GetCurrentPParamsGetCurrentPParams
amesgen
force-pushed
the
amesgen/pparams-encoding-compat
branch
from
f81b66d
to
01c0ceb
Compare
dnadales
reviewed
May 23, 2023
ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/Query.hs
Outdated
Show resolved
Hide resolved
dnadales
approved these changes
May 23, 2023
By introducing a newtype `LegacyPParams` we can create different `ToCBOR`/`FromCBOR` instances that matchup with the old and buggy serialization. We can then switch the en-/decoders used based on the negotiated protocol version in order to support older clients. Co-authored-by: Alexey Kuleshevich <[email protected]>
amesgen
force-pushed
the
amesgen/pparams-encoding-compat
branch
from
01c0ceb
to
f8072e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntersectMBO/ouroboros-network#4349 changed/fixed the encoding of
PParams, which broke compatibility of older clients with Node 8.0. This PR restores compatibility, by making the en-/decoding version-dependent.See the commit message for some implementation details. Also, note how the golden files changed due to this PR:
CardanoNodeToClientVersion <= 10; these are enabled byNodeToClient <= 14, which are the currently released node-to-client versions.CardanoNodeToClientVersion{11,12}(which are enabled byNodeToClientV_{15,16}).NodeToClientV_15will be released in Node 8.1, and indeed, we want to use the new and fixed encoding when this version is negotiated.