Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edp Comment Panel Styling #1811

Closed
James-Robe opened this issue Apr 24, 2018 · 4 comments
Closed

Edp Comment Panel Styling #1811

James-Robe opened this issue Apr 24, 2018 · 4 comments

Comments

@James-Robe
Copy link

James-Robe commented Apr 24, 2018

resulting from #1808

This ticket concerns the restyling of the edp, specifically the restyling of the comment panel (ie the form that users input comments into, such as reflections).

1[ x] Move comment panel (plan, build, reflect) to the left column for all edp stages.
2[ x] Integrate stage descriptions and stage title into the comment panel as per images.
2a[ ] Note: this includes updating the text for the reflect quiz AND reflect questions.
2b[ ] Part of this ticket is removing those old descriptions and titles as per the included images once they've been added to the comment panel.
3[ x] Restyle comment panels to be consistent with each other as per images
3a[ x] Remove "right" and "left" styling
3b[ x] Remove avatar.
3c[ x] Comment panels on all stages should be in the same position (ie left).

fireshot capture 20 - construct a crane i curi_ - http___127 0 0 1_8000_challenges_2_studentj1_plan_
fireshot capture 21 - construct a crane i cur_ - http___127 0 0 1_8000_challenges_2_studentj1_build_
fireshot capture 22 - construct a crane i c_ - http___127 0 0 1_8000_challenges_2_studentj1_reflect_
fireshot capture 23 - construct a crane i curi_ - http___127 0 0 1_8000_challenges_2_family_reflect_

@James-Robe James-Robe added the 3 - Iteration Backlog To do in the current iteration label Apr 24, 2018
@James-Robe James-Robe self-assigned this Apr 26, 2018
@James-Robe James-Robe added 4 - In Progress and removed 3 - Iteration Backlog To do in the current iteration labels Apr 26, 2018
James-Robe added a commit that referenced this issue Apr 30, 2018
impliments the vartious styling changes in #1811
@stenington stenington added this to the AIFC Stage 2 Start milestone May 4, 2018
@James-Robe
Copy link
Author

here is a comparison of the old and new with some notes as to what text relates to what and what questions still need to be answered: https://projects.invisionapp.com/freehand/document/MUoK8CrfK

stenington pushed a commit that referenced this issue May 15, 2018
impliments the vartious styling changes in #1811
stenington added a commit that referenced this issue May 15, 2018
* 1816 Moved the congrats box to right column

Work for #1816 additionally, I removed the avatar and center column for the layout. Remaining work: inspiration button needs to change once the native inspiration gallery upload feature is added ( #1815 )

* 1817 nav bar updates

the nav bar and header portion of #1817

* #1817 comment "timeline" changes

This handles the comment formatting changes outlined in #1817

* #1811 edp comment box styling

impliments the vartious styling changes in #1811

* removed unnecessary css

* removed middle panel and simplified negative margin

* fixed spacing

* removed under nav header

* updated "test" step description

* corrected an accidental code commit

This should be a link

* updated plan and build templates

removed the plan stage build call to action and the hardcoded testing phrase in the build stage.

* remove non utf-8 character
@audsbodin
Copy link

audsbodin commented May 22, 2018

"No file selected" text is hard to read, but white should work better

uploads/b0f068b0-82e5-46b4-a7dd-3340c263b845/Screenshot 2018-05-22 13.40.27.png

#1859 created to address this

@James-Robe
Copy link
Author

Build test redesign should be a different color (orange and pink)

@James-Robe
Copy link
Author

#1860 covers the scope of qa fixes for these tickets. (test is now orange)

stenington pushed a commit that referenced this issue Jun 4, 2018
* misc qa fixes

* updated as per PR and added button margin

* span is now really a span
@Allicolyer Allicolyer added the [Theme] EDP EDP improvement worth doing as soon as it's feasible label Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants