Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused DC fields #1844

Closed
James-Robe opened this issue May 14, 2018 · 1 comment
Closed

Remove unused DC fields #1844

James-Robe opened this issue May 14, 2018 · 1 comment

Comments

@James-Robe
Copy link

James-Robe commented May 14, 2018 •
edited by stenington
Loading

#1811 removes a the following 'subheaders' and 'call to action's from the template (an 'X' indicates it was removed). After these changes go to production, those removed fields should also be removed from the DC model, as they are now unused. That is the purpose of this ticket.

nimv2wq

Note that there is no 'call to action' for the reflect step.
Note that the call to action for the build step is KEPT. it should NOT be removed.
@James-Robe James-Robe added the 3 - Iteration Backlog To do in the current iteration label May 14, 2018
@James-Robe James-Robe self-assigned this May 14, 2018
@James-Robe James-Robe mentioned this issue Jun 5, 2018
Closed
@rsgonzal rsgonzal added tech debt technical decisions made that we know we need to revisit Stage 2 labels Jun 6, 2018
@James-Robe James-Robe added 4 - In Progress and removed 3 - Iteration Backlog To do in the current iteration labels Jun 12, 2018
James-Robe added a commit that referenced this issue Jun 12, 2018
@James-Robe
removed subheaders and call to actions that are not used
60cb45c 
#1844
James-Robe added a commit that referenced this issue Jun 12, 2018
@James-Robe
#1844 clean up fixtures
9153833
stenington pushed a commit that referenced this issue Jun 13, 2018
@James-Robe @stenington
#1844 removed unused challenge fields (#1873)
55e0355 
* removed subheaders and call to actions that are not used

#1844

* #1844 clean up fixtures
@rsgonzal
Copy link
Collaborator

looks good in staging! checked the DC pages too to make sure nothing was broken

@rsgonzal rsgonzal added the ready label Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stenington @rsgonzal @James-Robe