Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ml/JsonLD doesn't support PHP 7.2 #960

Closed
whikloj opened this issue Oct 25, 2018 · 12 comments
Closed

ml/JsonLD doesn't support PHP 7.2 #960

whikloj opened this issue Oct 25, 2018 · 12 comments

Comments

@whikloj
Copy link
Member

whikloj commented Oct 25, 2018

Chullo requires JsonLD (Islandora/chullo#73) but it doesn't support PHP 7.2 (lanthaler/JsonLD#88) and there is a PR (of mine) waiting to resolve this (lanthaler/JsonLD#92).

That PR has seen no reply nor activity in 6 months.

It is possible that this project is abandoned, we may have to fork it and move forward or pick another library to work with.

@acoburn
Copy link
Contributor

acoburn commented Nov 12, 2018

@whikloj I am very interested in knowing where you go with this issue. I have some code that suffers from the same limitation: it depends on ml/JsonLD; therefore, I can't support PHP 7.2. With JSON-LD 1.1 in the works, it seems important to find a project that is active and responsive.

@DiegoPino
Copy link
Contributor

DiegoPino commented Nov 12, 2018 via email

@whikloj
Copy link
Member Author

whikloj commented Nov 13, 2018

@acoburn @DiegoPino I am not sure what path to take with this. I'll be honest that the JSON-LD spec is still outside my comfort zone. Things like framing, etc are not clear to me. That being said we do need 7.2 support.

I am hesitant to fork this and to then take on the support of a new library as well, especially because of work load and my previously mentioned lack of clear context.

That being said I haven't found a more up-to-date and functional JSON-LD library for PHP than ml/JsonLD. If either of you have a contender, please note it here and perhaps we will have to consider switching libraries.

@DiegoPino
Copy link
Contributor

DiegoPino commented Nov 13, 2018

@whikloj I just left him another message. I know Markus is super busy but I don't lose hope he will merge it eventually.

@acoburn
Copy link
Contributor

acoburn commented Nov 13, 2018

I'm in the same boat as @whikloj: I am not in a position to manage a fork of the ml/JsonLd library. My interest here is just in having a functional JsonLD library for PHP 7.2. If I find one, I'll make a note of it here.

@DiegoPino
Copy link
Contributor

@acoburn sadly there are none. I tried digital bazaar's one but it's not composer ready, so quite a mess to use and the functionality provided was less clear. To be honest, most of my JSON-LD works which is a lot in the last months is only directly JSON-LD and quite mostly JSON, since I decided (my doctor told me so) to stay on JSON-LD and never ever try to move from/to other Semantic representations back and forth. The original use of JSON-LD Library in CLAW was also not much, could be refactored in case of emergency to a few arrays based helper methods. My Doctor knows feels triple base serializations are a mess. But that's me. Still, I would love to have framing around. And the changes on 1.1 are important, not sure if that will ever be covered in any of those libraries.

@DiegoPino
Copy link
Contributor

@whikloj @acoburn Markus merged Jared's pull!!! So this ticket can be closed 🍾 🎉
But, Drupal 8 does not officially (yet) support 7.2, side note just in case you are planning on testing against it.

@acoburn
Copy link
Contributor

acoburn commented Nov 19, 2018

@DiegoPino thanks, I saw this yesterday and already released a new version of StaticLDP, which meant I could move the required versions to 7.1.x and 7.2.x.

@DiegoPino
Copy link
Contributor

@acoburn cool! Since Silex is going away in favor of new Symfony, are you planning on moving forward with that too? I have some actual production uses for your static LDP imp. , so will be watching first/then contributing after Dec 10th, if you are interested in getting a hand there.

@acoburn
Copy link
Contributor

acoburn commented Nov 19, 2018

@DiegoPino thanks for the reminder about that. trellis-ldp/static-ldp#38 shall I assign you to that issue? 😄

Actually, I'm happy to do the work on that. I should be able to find some time in the next week or two.

@DiegoPino
Copy link
Contributor

@acoburn if you can wait for Dec 10th (that week) then yeah, but you are way better developer than me so feel free to move forward solo if you have time/energy 😄

@whikloj
Copy link
Member Author

whikloj commented Nov 21, 2018

Resolved with the merging of lanthaler/JsonLD#92

@whikloj whikloj closed this as completed Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants