Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-10091]: AUT Pre-Bash Updates #475

Merged
merged 3 commits into from
Oct 31, 2024
Merged

[MOB-10091]: AUT Pre-Bash Updates #475

merged 3 commits into from
Oct 31, 2024

Conversation

mprew97
Copy link
Contributor

@mprew97 mprew97 commented Oct 31, 2024

JIRA Ticket(s) if any

Description

Renames config var, cleans up sample app without JWT fixes

Test Steps

@@ -62,7 +66,7 @@ export const LoginFormWithoutJWT: FC<Props> = ({

const setUser = useEmail ? setEmail : setUserId;

setUser(user, true)
setUser(user)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still unsure how identityResolution is being used, should we expect it to be passed in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, identity resolution could be passed in. The config defaults are set to mergeOnAnonymousToKnown: true so just removing the variable here because it's redundant. The values for IdentityResolution, i.e., mergeOnAnonymousToKnown and replayOnVisitorToKnown could be passed in and changed any time setEmail or setUserId is called.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah so it's an override and there's logic in the implementation that pulls from the config? If so, could we label it as something like identityResolutionOverride in the function signatures where it would be an override?

Copy link
Contributor

@ts-nguyen ts-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mprew97 mprew97 merged commit baa3f7c into AUT_main Oct 31, 2024
1 check passed
@mprew97 mprew97 deleted the AUT-Final branch October 31, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants