Adds a delay to the group expansion #4838

johannes-manner · 2019-04-02T08:25:09Z

Adds a delay to the group expansion action. The delay is currently 1 second and only expands the group.

Is there also a need to collapse the item, if an user drags over it after a specific period?

Closes #4674

Change in CHANGELOG.md described
Manually tested changed features in running JabRef

tobiasdiez

Thanks for your PR. I've only two very small suggestions for improvement before we can merge.

tobiasdiez · 2019-04-02T10:58:35Z

src/main/java/org/jabref/gui/groups/GroupTreeView.java

@@ -220,7 +223,7 @@ public void initialize() {
                    event.acceptTransferModes(TransferMode.MOVE, TransferMode.LINK);

                    //expand node and all children on drag over
-                    row.getTreeItem().setExpanded(true);
+                    row.getTreeItem().setExpanded(previousDragOverTreeItem.expandGroup(row.getTreeItem()));


Please move the call to row.getTreeItem().setExpanded also to the expandGroup method (so that it does what it's name suggests).

tobiasdiez · 2019-04-02T10:59:35Z

src/main/java/org/jabref/gui/groups/GroupTreeView.java

@@ -399,4 +402,27 @@ private DroppingMouseLocation getDroppingMouseLocation(TreeTableRow<GroupNodeVie
            return DroppingMouseLocation.CENTER;
        }
    }
+
+    private class DragOverTreeItem {


Maybe rename to DragExpansionHandler or something like that? (because it is not really a TreeItem but some kind of wrapper)

buhtz · 2019-04-03T13:03:55Z

It is more then a "delay":

Drag one item to a closed group
Stop the mouse when the item is over the new group.
Don't move! Do nothing! Hold the mouse button (keep dragging!)
You can wait until the hell is frozen. Nothing happens. The group never expands.
Move a little bit -> then the group expands.

Second problem:
The group does not only expand it makes the complete tree scroll. When the group expands (e.g. with 12 child groups in it) the group moves away from the mouse cursor. Now the last child group is under the mouse courser.

Third problem (not quite related to that Issue):
When dragging an item on top or buttom of the tree it does not scroll. I am not able to scroll while dragging. This is also unusual.
I have no idea about Java and the libraries it offers. I would recommand to save ressources, kill the complete tree control look for a better one.

AEgit · 2019-04-08T09:47:13Z

JabRef 5.0-dev--snapshot--2019-04-08--master--3d2d61d0c
Windows 10 10.0 amd64
Java 1.8.0_201

Regarding the issues reported by @noMICROSOFTbuhtz

Problem 1:
When I stop with the mouse over the new group, it will always open (so no need for me to move the mouse a little bit), BUT after one or two seconds it will close again. If you keep your mouse over the group it will continuously open and close with a period of one or two seconds. That is definitely annoying and I do not think that is intended. I reckon it should stay open, once you have waited for one or two seconds.

Problem 2:
I can confirm that the complete group expands and I see the group tree scrolling, but it has not happened to me so far, that the group of interest has moved away from the mouse cursor. So I am currently only able to replicate part of the problem (but that might be specific to how many groups/subgroups you have?).

Problem 3:
I can absolutely confirm this issue. I have reported this before here:
#2869

and I have mentioned it again here:
#4869 (comment) (last paragraph).

716f635 Update changes in Harvard-Stellenbosch (JabRef#4862) a6a9a1a Create alkoholizmus-a-drogove-zavislosti.csl (JabRef#4859) 0560ca0 Update journal-of-the-american-college-of-surgeons.csl (JabRef#4858) 9e16631 create independent style for cellular-and-molecular-gastroenterology-and-hepatology.csl (JabRef#4852) 87b0853 Update antiquity.csl (JabRef#4841) cb4e7f7 Update heart-rhythm.csl (JabRef#4850) b3b55ee Create iisue-moderno (JabRef#4846) 63973a7 Create etasr.csl (JabRef#4848) 9942138 Create style for Journal of Vertebrate Biology (JabRef#4849) 7c7f3d3 Add Future Medicine dependents (JabRef#4838) abe2066 Update methods-of-information-in-medicine.csl (JabRef#4847) c64d98b create independent style for new-zealand-journal-of-forestry-science (JabRef#4844) 28265f9 Create continuity-and-change.csl (JabRef#4839) d065fdd Create journal-of-clinical-ethics.csl (JabRef#4842) b9fbfa3 Update future-medicine.csl (JabRef#4843) ceb56fa Create future-medicine.csl (JabRef#4834) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 716f635

* Squashed 'src/main/resources/csl-styles/' changes from 586e0b8..c5f14e2 c5f14e2 Update journal-of-plant-ecology.csl (#4837) b5d00ab Hotfix: pravnik.csl & iso690-full-note-cs.csl (#4833) fb8d48a add PMID and DOI (#4832) 7ebdfff Update lancaster-university-harvard.csl (#4836) 8771e21 Create journal-of-clinical-neurology.csl (#4835) 70beb7b Harvard Lancaster: Fix in-text locator 0709b73 Update informal-logic.csl (#4831) d18d133 Update gost-r-7-0-5-2008.csl (#4829) cfb5389 Update gost-r-7-0-5-2008-numeric.csl (#4828) 0fc46ea Update gost-r-7-0-5-2008-numeric-alphabetical.csl (#4827) fac26cb Create feminist-theory.csl (#4830) a2721e6 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl, and iso690-full-note-cs.csl (#4826) 2f0d735 Improve localization of DGfP 683d7d1 Create zeitschrift-fur-theologie-und-philosophie.csl (#4813) 7c82406 always show DOI in aps.csl (#4820) 1eb531d Update journal-of-international-business-studies.csl (#4819) 9caf926 Create interdisziplinare-anthropologie.csl (#4818) 00210e1 UKSW2 (#4807) 015db6e UKSW1 (#4800) f706ef5 Update masarykova-univerzita-pravnicka-fakulta.csl (#4822) 096108d Update epilepsia.csl (#4823) 07ebdc3 Update eksploatacja-i-niezawodnosc.csl (#4824) 3d50f3c Create ABNT-Universidade-Federal-de-Pernambuco-CFCH.csl (#4798) df94fa1 Update eksploatacja-i-niezawodnosc.csl (#4808) 4089be5 Update bulletin-de-la-societe-prehistorique-francaise.csl (#4810) f130aa7 Update molecular-biology-and-evolution.csl (#4814) 86f452f Create heiliger-dienst.csl (#4815) 5ccd3e9 Update revista-brasileira-de-ciencia-do-solo.csl (#4817) 0eea734 Fix a delimiter in journal-of-the-royal-society-of-western-australia.csl (#4811) 1cbe790 Delete heiliger-dienst.csl 19fa29f Create heiliger-dienst.csl (#4787) 888bad1 Update RMIT Harvard to match Easy Cite (#4788) 46011dd Create universite-nangui-abrogoua-ufr-sn (#4676) 174adab Create apa-6th-edition-no-ampersand.csl (#4767) 03cf65f Create journal-of-plant-protection-research.csl (#4797) c749084 Update eksploatacja-i-niezawodnosc.csl (#4782) 17e1501 Update masarykova-univerzita-pravnicka-fakulta.csl (#4783) 5596d18 Update revista-brasileira-de-ciencia-do-solo.csl (#4790) 9c1a381 create csl for the journal Textual Cultures (#4785) 8345762 Update taylor-and-francis-national-library-of-medicine.csl (#4786) 5ec1acf Create british-journal-of-criminology.csl (#4789) 68550ac Update angewandte-chemie.csl (#4791) 09e2755 Create shock.csl (#4792) d46e49e Update antioxidants-and-redox-signaling.csl (#4793) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: c5f14e2 * Squashed 'src/main/resources/csl-styles/' changes from c5f14e2..716f635 716f635 Update changes in Harvard-Stellenbosch (#4862) a6a9a1a Create alkoholizmus-a-drogove-zavislosti.csl (#4859) 0560ca0 Update journal-of-the-american-college-of-surgeons.csl (#4858) 9e16631 create independent style for cellular-and-molecular-gastroenterology-and-hepatology.csl (#4852) 87b0853 Update antiquity.csl (#4841) cb4e7f7 Update heart-rhythm.csl (#4850) b3b55ee Create iisue-moderno (#4846) 63973a7 Create etasr.csl (#4848) 9942138 Create style for Journal of Vertebrate Biology (#4849) 7c7f3d3 Add Future Medicine dependents (#4838) abe2066 Update methods-of-information-in-medicine.csl (#4847) c64d98b create independent style for new-zealand-journal-of-forestry-science (#4844) 28265f9 Create continuity-and-change.csl (#4839) d065fdd Create journal-of-clinical-ethics.csl (#4842) b9fbfa3 Update future-medicine.csl (#4843) ceb56fa Create future-medicine.csl (#4834) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 716f635 * Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63 a995c63 Create errata.csl (#4894) 883b9cd Update archeologie-medievale.csl (#4892) a942b5c Update rmit-university-harvard.csl (#4890) 5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (#4891) f2a8fe3 Fix AVMA style c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (#4872) 9f106eb Update rmit-university-harvard.csl (#4884) 5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (#4886) 7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (#4871) ae5eba3 Create revue-archeologique-de-lest.csl (#4881) 58a1672 Create pacific-conservation-biology.csl (#4880) 381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (#4879) c66a5c0 Create society-of-biblical-literature-author-date.csl (#4812) 008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (#4874) 193385a Update manchester (#4878) fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (#4856) 2f70b14 Add "personal communication" to remaining APA locales (#4866) 2b4f831 Fixed page-range-format (#4863) d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (#4860) e433c99 fix delimiter issue for bioscience.csl (#4876) 4d97aab update et-al settings for stroke.csl (#4875) 342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (#4868) 91fe25e Add article number to IEEE (#4867) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: a995c63 * Squashed 'src/main/resources/csl-styles/' changes from a995c63..bf698ac bf698ac Create common-market-law-review.csl (#4910) c962eca Create harvard-prifysgol-caerdydd.csl (#4922) 0c24e7f Update gewerblicher-rechtsschutz-und-urheberrecht.csl (#4923) d2ec1a7 Create Tijdschrift-voor-Geneeskunde.csl (#4907) 5df7250 Update harvard-institut-fur-praxisforschung-de.csl (#4918) 093fd91 Update universite-de-montreal-apa.csl (#4916) a3e41d4 Update thieme-german.csl (#4919) 648765a add DOI to aerosol-science-and-technology.csl (#4909) bc1ebee Reindent/reorder a8dc18a Fix documentation link for epidemiology & infection aab403a Fix AGLC Newspaper date 4c018d5 Add period between editor and translator (SBL styles) (#4906) 42f7491 Create geographische-zeitschrift.csl (#4898) a4002a6 Create german-kunstwissenschaft.csl (#4896) b01910b Disambiguation of names (#4895) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: bf698ac * Squashed 'src/main/resources/csl-styles/' changes from bf698ac..7cab2f7 7cab2f7 Create depro-ufs.csl (#4947) 2fcda1f Create journal-of-sport-science-and-medicine.csl (#4949) cd457d4 Update american-marketing-association.csl (#4945) cacc4ee Create nejm-catalyst.csl (#4943) bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (#4941) 1f706cd Update health-services-research.csl (#4939) 76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (#4932) e79640e Create afro-asia.csl (#4934) c601aa4 Update lancaster-university-harvard.csl (#4938) 184fd90 Update collection-du-centre-jean-berard.csl (#4936) 82f9aec fix et-al & add DOI thyroid.csl (#4937) 4af169f Create universidade-estadual-de-alagoas-uneal-abnt (#4885) 47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (#4905) 3cab27d Update thieme-german.csl (#4931) eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (#4925) 4adb1ea Create karstenia.csl (#4929) 530a136 Fix author substitute in Universita Cattolica git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 7cab2f7 * Squashed 'src/main/resources/csl-styles/' changes from 7cab2f7..827b986 827b986 add DOI preprint to american-society-for-microbiology.csl (#4946) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 827b986 * Squashed 'src/main/resources/csl-styles/' changes from 827b986..eb0d37e eb0d37e Create natbib-plainnat-author-dat.csl (#4967) fb1592a Update journal-of-fish-biology.csl (#4969) f6876cb Update .travis.yml (#4970) d6d400b Create london-review-of-international-law.csl (#4966) d2a5ae1 Update harvard-stellenbosch-university.csl (#4965) 9c62141 Create phytopathologia-mediterranea.csl (#4964) 8ca2ea1 Update historical-materialism.csl (#4960) 80456dc Update historical-materialism.csl be2d910 Update historical-materialism.csl 1d1cf09 Create atlande.csl (#4930) 89f41d4 Create juristische-zitierweise-oeffentliches-recht.csl (#4944) 8c677a0 Create korean-journal-of-gastroenterology.csl (#4954) eadb950 Create historical-materialism.csl (#4955) 5553dcd Create revista-materia.csl (#4957) d23a3ab Bug fix in APA 6 original publication macro (#4959) 66f9974 Always print publisher in APA 6th edition (#4899) 868809c Create agora.csl (#4940) 99c19c3 Update anthropologie-et-societes.csl (#4952) ee17423 Create critical-reviews-in-solid-state-and-materials-science.csl (#4951) 7a13a7d Create korean-journal-of-internal-medicine.csl (#4953) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: eb0d37e * Merged new library actions * l10n * Removed unused constructor * Fixed checkstyle failed check * Fixed one more checkstyle issue Co-authored-by: github actions <[email protected]>

Adds a delay to the group expansion

62c1775

Siedlerchr approved these changes Apr 2, 2019

View reviewed changes

Also collapses the item after 1 second

50ab654

johannes-manner added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 2, 2019

tobiasdiez requested changes Apr 2, 2019

View reviewed changes

Renamed handler class and method signature

cc5c14e

tobiasdiez merged commit 3ed41ef into JabRef:master Apr 2, 2019

AEgit mentioned this pull request Apr 8, 2019

Automatic unfold while drag is to fast / sensitive #4674

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds a delay to the group expansion #4838

Adds a delay to the group expansion #4838

johannes-manner commented Apr 2, 2019

tobiasdiez left a comment

tobiasdiez Apr 2, 2019

tobiasdiez Apr 2, 2019

buhtz commented Apr 3, 2019

AEgit commented Apr 8, 2019

Adds a delay to the group expansion #4838

Adds a delay to the group expansion #4838

Conversation

johannes-manner commented Apr 2, 2019

tobiasdiez left a comment

Choose a reason for hiding this comment

tobiasdiez Apr 2, 2019

Choose a reason for hiding this comment

tobiasdiez Apr 2, 2019

Choose a reason for hiding this comment

buhtz commented Apr 3, 2019

AEgit commented Apr 8, 2019