Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting Rid of Swing #4894

Merged
merged 30 commits into from
Aug 23, 2019
Merged

Getting Rid of Swing #4894

merged 30 commits into from
Aug 23, 2019

Conversation

LinusDietz
Copy link
Member

Since we made good progress in removing Swing so far, I created an architecture test to check if Swing and JGoodies is still used.

Also, I could delete quite some unused classes.

Can only be merged, if Swing is entirely removed.

@LinusDietz LinusDietz added build-system type: code-quality Issues related to code or architecture decisions labels Apr 18, 2019
@LinusDietz LinusDietz added this to the v5.0 milestone Apr 18, 2019
@LinusDietz LinusDietz mentioned this pull request Apr 18, 2019
Closed
36 tasks
@Siedlerchr
Copy link
Member

Siedlerchr commented Apr 18, 2019 •
edited
Loading

General things: Undo/Redo

Classes which need some further conversion;
EmacsKeybinding (does anyone use that?) -> done
MergeSharedEntryDialog (we do have a merge dialog, can we reuse it?)
org.jabref.gui.importer.actions.CheckForNewEntryTypesAction.createCheckBoxPane

GroupTreeNodeViewModel => Can this be removed or converted?

FileListTableModel -> can be removed, basePanel method must be adjusted to linkedFiles dialog ->done

@Siedlerchr
remove some more keybindings
3418ca6 
remove locale setting for swing
remove obsolete special fields drop down
Siedlerchr and others added 4 commits April 30, 2019 18:16
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into swing-test
91e6572 
* upstream/master: (29 commits)
  Improve author parsing (#4931)
  Ui preferences global modifications (#4926)
  Bump checkstyle from 8.19 to 8.20 (#4928)
  Bump mysql-connector-java from 8.0.15 to 8.0.16 (#4924)
  UI Preferences->advanced tab optimization : separators and text modification (#4922)
  Fix for the issue #4912 (#4916)
  Refactorings, move functionality of CustomEntryTypesManager to Preferences Use ObservableList instead of LIstProperty
  Toggle enable status of menu items (#4872)
  Fixes throwing an exception when 'id' field is present in bib file (#4918)
  Quick fix for error when opening preferences (#4917)
  Revert "Create new layout for preferences regarding columns"
  Create new layout for preferences regarding columns
  Rearrange the padding of the "Append library" dialog (#4914)
  Make Group dialog resizable (#4910)
  Adjust save exception to inlcude orgininal stack traces
  remove dialogService parameter
  remove dialog service argument
  rework dialog, create fxml etc fix l10n Remove obsolete code
  rework threading stuff simplify code
  Fix Some Codacy Code Convention Issues (#4904)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/JabRefFrame.java
#	src/main/java/org/jabref/gui/customentrytypes/FieldSetComponent.java
@Siedlerchr
remove emacs keybinding
672ca79
@Siedlerchr
remove emacs keybinding rest
47cac3e
@LinusDietz
Improve tests to exclude the UndoManager
2104788
@LinusDietz
Copy link
Member Author

LinusDietz commented May 2, 2019 •
edited by Siedlerchr
Loading

To move on with this, I have excluded the UndoManager from the checks. However, we still have 90 violations.

java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'no classes should access classes that reside in any package ['javax.swing', 'javax.swing.border..', 'javax.swing.colorchooser..', 'javax.swing.event..', 'javax.swing.filechooser..', 'javax.swing.plaf..', 'javax.swing.table..', 'javax.swing.text..', 'javax.swing.tree..']' was violated (90 times):
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls constructor <javax.swing.DefaultListModel.<init>()> in (FieldSetComponent.java:83)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls constructor <javax.swing.JButton.<init>(java.lang.String)> in (FieldSetComponent.java:81)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls constructor <javax.swing.JButton.<init>(java.lang.String)> in (FieldSetComponent.java:82)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls constructor <javax.swing.JButton.<init>(javax.swing.Icon)> in (FieldSetComponent.java:125)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls constructor <javax.swing.JButton.<init>(javax.swing.Icon)> in (FieldSetComponent.java:126)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls constructor <javax.swing.JComboBox.<init>([Ljava.lang.Object;)> in (FieldSetComponent.java:162)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls constructor <javax.swing.JLabel.<init>(java.lang.String)> in (FieldSetComponent.java:86)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls constructor <javax.swing.JList.<init>(javax.swing.ListModel)> in (FieldSetComponent.java:92)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls constructor <javax.swing.JPanel.<init>()> in (FieldSetComponent.java:79)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls constructor <javax.swing.JScrollPane.<init>(java.awt.Component, int, int)> in (FieldSetComponent.java:117)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls constructor <javax.swing.JTextField.<init>(int)> in (FieldSetComponent.java:157)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls method <javax.swing.Box.createHorizontalStrut(int)> in (FieldSetComponent.java:138)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls method <javax.swing.DefaultListModel.addElement(java.lang.Object)> in (FieldSetComponent.java:90)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls method <javax.swing.JButton.addActionListener(java.awt.event.ActionListener)> in (FieldSetComponent.java:104)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls method <javax.swing.JButton.addActionListener(java.awt.event.ActionListener)> in (FieldSetComponent.java:127)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls method <javax.swing.JButton.addActionListener(java.awt.event.ActionListener)> in (FieldSetComponent.java:128)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls method <javax.swing.JButton.addActionListener(java.awt.event.ActionListener)> in (FieldSetComponent.java:95)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls method <javax.swing.JButton.setToolTipText(java.lang.String)> in (FieldSetComponent.java:129)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls method <javax.swing.JButton.setToolTipText(java.lang.String)> in (FieldSetComponent.java:130)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls method <javax.swing.JComboBox.setEditable(boolean)> in (FieldSetComponent.java:163)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls method <javax.swing.JList.addFocusListener(java.awt.event.FocusListener)> in (FieldSetComponent.java:175)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls method <javax.swing.JList.setSelectionMode(int)> in (FieldSetComponent.java:93)
Constructor <org.jabref.gui.customentrytypes.FieldSetComponent.<init>(java.lang.String, java.util.List, java.util.List, java.lang.String, java.lang.String, boolean, boolean)> calls method <javax.swing.JTextField.addActionListener(java.awt.event.ActionListener)> in (FieldSetComponent.java:158)
Constructor <org.jabref.gui.search.SearchWorker.<init>(org.jabref.gui.BasePanel, org.jabref.logic.search.SearchQuery, org.jabref.gui.search.SearchDisplayMode)> calls constructor <javax.swing.SwingWorker.<init>()> in (SearchWorker.java:32)
Constructor <org.jabref.gui.shared.MergeSharedEntryDialog.<init>(org.jabref.gui.JabRefFrame, org.jabref.model.database.shared.DatabaseSynchronizer, org.jabref.model.entry.BibEntry, org.jabref.model.entry.BibEntry, org.jabref.model.database.BibDatabaseMode)> calls constructor <javax.swing.JDialog.<init>(java.awt.Frame, java.lang.String, boolean)> in (MergeSharedEntryDialog.java:43)
Method <org.jabref.gui.BasePanel.markBaseChanged()> calls method <javax.swing.SwingUtilities.invokeAndWait(java.lang.Runnable)> in (BasePanel.java:977)
Method <org.jabref.gui.BasePanel.markBaseChanged()> calls method <javax.swing.SwingUtilities.isEventDispatchThread()> in (BasePanel.java:973)
Method <org.jabref.gui.JabRefFrame$1.run()> calls method <javax.swing.SwingUtilities.invokeLater(java.lang.Runnable)> in (JabRefFrame.java:295)
Method <org.jabref.gui.customentrytypes.FieldSetComponent$FieldListFocusListener.focusGained(java.awt.event.FocusEvent)> calls method <javax.swing.JList.getSelectedValue()> in (FieldSetComponent.java:340)
Method <org.jabref.gui.customentrytypes.FieldSetComponent$FieldListFocusListener.focusGained(java.awt.event.FocusEvent)> calls method <javax.swing.JList.setSelectedIndex(int)> in (FieldSetComponent.java:341)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.addField(java.lang.String)> calls method <javax.swing.DefaultListModel.contains(java.lang.Object)> in (FieldSetComponent.java:238)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.addField(java.lang.String)> calls method <javax.swing.JOptionPane.showMessageDialog(java.awt.Component, java.lang.Object, java.lang.String, int)> in (FieldSetComponent.java:246)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.addFieldUncritically(java.lang.String)> calls method <javax.swing.DefaultListModel.addElement(java.lang.Object)> in (FieldSetComponent.java:260)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.addListDataListener(javax.swing.event.ListDataListener)> calls method <javax.swing.DefaultListModel.addListDataListener(javax.swing.event.ListDataListener)> in (FieldSetComponent.java:307)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.addListSelectionListener(javax.swing.event.ListSelectionListener)> calls method <javax.swing.JList.addListSelectionListener(javax.swing.event.ListSelectionListener)> in (FieldSetComponent.java:295)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.getFields()> calls method <javax.swing.DefaultListModel.elements()> in (FieldSetComponent.java:222)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.getFields()> calls method <javax.swing.DefaultListModel.getSize()> in (FieldSetComponent.java:221)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.getFirstSelected()> calls method <javax.swing.JList.getSelectedValue()> in (FieldSetComponent.java:198)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.lambda$new$0(java.awt.event.ActionEvent)> calls method <javax.swing.JComboBox.getSelectedItem()> in (FieldSetComponent.java:97)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.lambda$new$0(java.awt.event.ActionEvent)> calls method <javax.swing.JComboBox.getSelectedItem()> in (FieldSetComponent.java:98)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.lambda$new$0(java.awt.event.ActionEvent)> calls method <javax.swing.JTextField.getText()> in (FieldSetComponent.java:100)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.lambda$new$0(java.awt.event.ActionEvent)> calls method <javax.swing.JTextField.getText()> in (FieldSetComponent.java:101)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.lambda$new$4(java.awt.event.ActionEvent)> calls method <javax.swing.JTextField.getText()> in (FieldSetComponent.java:158)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.move(int)> calls method <javax.swing.DefaultListModel.add(int, java.lang.Object)> in (FieldSetComponent.java:323)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.move(int)> calls method <javax.swing.DefaultListModel.get(int)> in (FieldSetComponent.java:319)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.move(int)> calls method <javax.swing.DefaultListModel.remove(int)> in (FieldSetComponent.java:322)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.move(int)> calls method <javax.swing.DefaultListModel.size()> in (FieldSetComponent.java:321)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.move(int)> calls method <javax.swing.JList.getSelectedIndex()> in (FieldSetComponent.java:315)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.move(int)> calls method <javax.swing.JList.setSelectedIndex(int)> in (FieldSetComponent.java:324)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.removeSelected()> calls method <javax.swing.DefaultListModel.removeElementAt(int)> in (FieldSetComponent.java:274)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.removeSelected()> calls method <javax.swing.JList.getSelectedIndices()> in (FieldSetComponent.java:269)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.selectField(java.lang.String)> calls method <javax.swing.DefaultListModel.indexOf(java.lang.Object)> in (FieldSetComponent.java:183)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.selectField(java.lang.String)> calls method <javax.swing.JList.getCellBounds(int, int)> in (FieldSetComponent.java:190)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.selectField(java.lang.String)> calls method <javax.swing.JList.setSelectedIndex(int)> in (FieldSetComponent.java:185)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.selectField(java.lang.String)> calls method <javax.swing.JScrollPane.getViewport()> in (FieldSetComponent.java:189)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.selectField(java.lang.String)> calls method <javax.swing.JViewport.scrollRectToVisible(java.awt.Rectangle)> in (FieldSetComponent.java:192)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.setEnabled(boolean)> calls method <javax.swing.JButton.setEnabled(boolean)> in (FieldSetComponent.java:210)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.setEnabled(boolean)> calls method <javax.swing.JButton.setEnabled(boolean)> in (FieldSetComponent.java:211)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.setEnabled(boolean)> calls method <javax.swing.JButton.setEnabled(boolean)> in (FieldSetComponent.java:213)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.setEnabled(boolean)> calls method <javax.swing.JButton.setEnabled(boolean)> in (FieldSetComponent.java:214)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.setEnabled(boolean)> calls method <javax.swing.JComboBox.setEnabled(boolean)> in (FieldSetComponent.java:207)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.setEnabled(boolean)> calls method <javax.swing.JTextField.setEnabled(boolean)> in (FieldSetComponent.java:204)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.setFields(java.util.Set)> calls constructor <javax.swing.DefaultListModel.<init>()> in (FieldSetComponent.java:280)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.setFields(java.util.Set)> calls method <javax.swing.DefaultListModel.addElement(java.lang.Object)> in (FieldSetComponent.java:282)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.setFields(java.util.Set)> calls method <javax.swing.DefaultListModel.addListDataListener(javax.swing.event.ListDataListener)> in (FieldSetComponent.java:286)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.setFields(java.util.Set)> calls method <javax.swing.JList.setModel(javax.swing.ListModel)> in (FieldSetComponent.java:288)
Method <org.jabref.gui.customentrytypes.FieldSetComponent.setListSelectionMode(int)> calls method <javax.swing.JList.setSelectionMode(int)> in (FieldSetComponent.java:179)
Method <org.jabref.gui.groups.GroupTreeNodeViewModel.expandSubtree(javax.swing.JTree)> calls method <javax.swing.JTree.expandPath(javax.swing.tree.TreePath)> in (GroupTreeNodeViewModel.java:142)
Method <org.jabref.gui.groups.GroupTreeNodeViewModel.getTreePath()> calls constructor <javax.swing.tree.TreePath.<init>([Ljava.lang.Object;)> in (GroupTreeNodeViewModel.java:179)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.mergeEntries()> calls method <javax.swing.JDialog.dispose()> in (MergeSharedEntryDialog.java:111)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showConfirmationDialog()> calls method <javax.swing.JDialog.dispose()> in (MergeSharedEntryDialog.java:102)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showConfirmationDialog()> calls method <javax.swing.JOptionPane.showConfirmDialog(java.awt.Component, java.lang.Object, java.lang.String, int)> in (MergeSharedEntryDialog.java:97)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showMergeDialog()> calls constructor <javax.swing.JButton.<init>(java.lang.String)> in (MergeSharedEntryDialog.java:73)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showMergeDialog()> calls constructor <javax.swing.JButton.<init>(java.lang.String)> in (MergeSharedEntryDialog.java:76)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showMergeDialog()> calls constructor <javax.swing.JLabel.<init>(java.lang.String)> in (MergeSharedEntryDialog.java:67)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showMergeDialog()> calls constructor <javax.swing.JPanel.<init>()> in (MergeSharedEntryDialog.java:79)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showMergeDialog()> calls constructor <javax.swing.border.EmptyBorder.<init>(int, int, int, int)> in (MergeSharedEntryDialog.java:68)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showMergeDialog()> calls method <javax.swing.JButton.addActionListener(java.awt.event.ActionListener)> in (MergeSharedEntryDialog.java:74)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showMergeDialog()> calls method <javax.swing.JButton.addActionListener(java.awt.event.ActionListener)> in (MergeSharedEntryDialog.java:77)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showMergeDialog()> calls method <javax.swing.JDialog.add(java.awt.Component, java.lang.Object)> in (MergeSharedEntryDialog.java:70)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showMergeDialog()> calls method <javax.swing.JDialog.add(java.awt.Component, java.lang.Object)> in (MergeSharedEntryDialog.java:71)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showMergeDialog()> calls method <javax.swing.JDialog.add(java.awt.Component, java.lang.Object)> in (MergeSharedEntryDialog.java:83)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showMergeDialog()> calls method <javax.swing.JDialog.addWindowListener(java.awt.event.WindowListener)> in (MergeSharedEntryDialog.java:85)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showMergeDialog()> calls method <javax.swing.JDialog.pack()> in (MergeSharedEntryDialog.java:92)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showMergeDialog()> calls method <javax.swing.JDialog.setDefaultCloseOperation(int)> in (MergeSharedEntryDialog.java:84)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showMergeDialog()> calls method <javax.swing.JDialog.setMinimumSize(java.awt.Dimension)> in (MergeSharedEntryDialog.java:50)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showMergeDialog()> calls method <javax.swing.JDialog.setVisible(boolean)> in (MergeSharedEntryDialog.java:93)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showMergeDialog()> calls method <javax.swing.JLabel.setBorder(javax.swing.border.Border)> in (MergeSharedEntryDialog.java:68)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showMergeDialog()> calls method <javax.swing.JPanel.add(java.awt.Component, java.lang.Object)> in (MergeSharedEntryDialog.java:80)
Method <org.jabref.gui.shared.MergeSharedEntryDialog.showMergeDialog()> calls method <javax.swing.JPanel.add(java.awt.Component, java.lang.Object)> in (MergeSharedEntryDialog.java:81)

@Siedlerchr
Copy link
Member

Siedlerchr commented May 2, 2019 •
edited
Loading

I thought we removed the custom entry types? #4716

Search worker is handled in #4897

@LinusDietz
Copy link
Member Author

I thought we removed the custom entry types? #4716

Yep, just deleted it again

@Siedlerchr Siedlerchr mentioned this pull request May 18, 2019
Closed
@LinusDietz
Merge branch 'master' into swing-test
fa25c93 
# Conflicts:
#	src/main/java/org/jabref/gui/BasePanel.java
#	src/main/java/org/jabref/gui/externalfiletype/ExternalFileMenuItem.java
#	src/main/java/org/jabref/gui/groups/WarnAssignmentSideEffects.java
#	src/main/java/org/jabref/gui/specialfields/SpecialFieldDropDown.java
#	src/main/java/org/jabref/gui/specialfields/SpecialFieldUpdateListener.java
@LinusDietz
fix mods tests
3e1270d
@LinusDietz
Merge pull request #5189 from JabRef/fix-swing-test
a78f1be 
fix mods tests
LinusDietz
LinusDietz commented Aug 13, 2019
View reviewed changes
src/main/java/org/jabref/preferences/JabRefPreferences.java
@@ -600,7 +600,7 @@ private JabRefPreferences() {
defaults.put(SHOW_ADVANCED_HINTS, Boolean.TRUE);
defaults.put(RENAME_ON_MOVE_FILE_TO_FILE_DIR, Boolean.TRUE);

defaults.put(FONT_STYLE, Font.PLAIN);
defaults.put(FONT_STYLE, 0); //for backwards compatibility, is equal to java.awt.Font.PLAIN
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a merge error?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this is correct, see the comment.

@LinusDietz LinusDietz changed the title [WIP] Getting Rid of Swing Getting Rid of Swing Aug 14, 2019
@LinusDietz LinusDietz added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 14, 2019
@LinusDietz
Copy link
Member Author

I would propose to merge this one and create a similar followup PR, but without the exceptions defined here: https://github.com/JabRef/jabref/pull/4894/files#diff-f64d223f20f6b0e53b00c8dbd2be2ce1R23

@Siedlerchr
Merge remote-tracking branch 'upstream/master' into swing-test
18ccbb4 
* upstream/master:
  Bugfix/5045 : Modified the existing logic to comply crossref resolution with biblatex specification (#5086)
  Fix issue with missing year value in year column (#5197)
  Bump com.gradle.build-scan from 2.4 to 2.4.1 (#5199)
  Add citation commands to TexParser: autocite, blockcquote, and textcquote (#5195)
  Conversion of preferencesDialog/advancedTab, networkTab and groupsTab to mvvm (#5141)
  Fix Permissions of LaTeXintegration (#5134)
  Border for group color indicator and some space for tooltip (#5190)
  Fix issue 5152, tooltip and icon added to group cell (#5191)
  Fix tooltips in CitationsDisplay (#5188)
@Siedlerchr
Copy link
Member

Siedlerchr commented Aug 23, 2019 •
edited
Loading

All swing related code except for the undo manager is removed

@Siedlerchr Siedlerchr merged commit 854cd51 into master Aug 23, 2019
@Siedlerchr Siedlerchr deleted the swing-test branch August 23, 2019 18:34
@tobiasdiez tobiasdiez mentioned this pull request Feb 26, 2020
Closed
github-actions bot pushed a commit to RamonG92/jabref that referenced this pull request Jul 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63
d47899e 
a995c63 Create errata.csl (JabRef#4894)
883b9cd Update archeologie-medievale.csl (JabRef#4892)
a942b5c Update rmit-university-harvard.csl (JabRef#4890)
5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4891)
f2a8fe3 Fix AVMA style
c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4872)
9f106eb Update rmit-university-harvard.csl (JabRef#4884)
5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (JabRef#4886)
7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (JabRef#4871)
ae5eba3 Create revue-archeologique-de-lest.csl (JabRef#4881)
58a1672 Create pacific-conservation-biology.csl (JabRef#4880)
381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (JabRef#4879)
c66a5c0 Create society-of-biblical-literature-author-date.csl (JabRef#4812)
008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (JabRef#4874)
193385a Update manchester (JabRef#4878)
fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (JabRef#4856)
2f70b14 Add "personal communication" to remaining APA locales (JabRef#4866)
2b4f831 Fixed page-range-format (JabRef#4863)
d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (JabRef#4860)
e433c99 fix delimiter issue for bioscience.csl (JabRef#4876)
4d97aab update et-al settings for stroke.csl (JabRef#4875)
342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4868)
91fe25e Add article number to IEEE (JabRef#4867)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a995c63
github-actions bot pushed a commit to CaptainDaVinci/jabref that referenced this pull request Jul 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63
cbfb751 
a995c63 Create errata.csl (JabRef#4894)
883b9cd Update archeologie-medievale.csl (JabRef#4892)
a942b5c Update rmit-university-harvard.csl (JabRef#4890)
5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4891)
f2a8fe3 Fix AVMA style
c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4872)
9f106eb Update rmit-university-harvard.csl (JabRef#4884)
5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (JabRef#4886)
7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (JabRef#4871)
ae5eba3 Create revue-archeologique-de-lest.csl (JabRef#4881)
58a1672 Create pacific-conservation-biology.csl (JabRef#4880)
381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (JabRef#4879)
c66a5c0 Create society-of-biblical-literature-author-date.csl (JabRef#4812)
008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (JabRef#4874)
193385a Update manchester (JabRef#4878)
fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (JabRef#4856)
2f70b14 Add "personal communication" to remaining APA locales (JabRef#4866)
2b4f831 Fixed page-range-format (JabRef#4863)
d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (JabRef#4860)
e433c99 fix delimiter issue for bioscience.csl (JabRef#4876)
4d97aab update et-al settings for stroke.csl (JabRef#4875)
342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4868)
91fe25e Add article number to IEEE (JabRef#4867)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a995c63
github-actions bot pushed a commit to ddunig2/jabref that referenced this pull request Jul 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63
a08213c 
a995c63 Create errata.csl (JabRef#4894)
883b9cd Update archeologie-medievale.csl (JabRef#4892)
a942b5c Update rmit-university-harvard.csl (JabRef#4890)
5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4891)
f2a8fe3 Fix AVMA style
c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4872)
9f106eb Update rmit-university-harvard.csl (JabRef#4884)
5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (JabRef#4886)
7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (JabRef#4871)
ae5eba3 Create revue-archeologique-de-lest.csl (JabRef#4881)
58a1672 Create pacific-conservation-biology.csl (JabRef#4880)
381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (JabRef#4879)
c66a5c0 Create society-of-biblical-literature-author-date.csl (JabRef#4812)
008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (JabRef#4874)
193385a Update manchester (JabRef#4878)
fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (JabRef#4856)
2f70b14 Add "personal communication" to remaining APA locales (JabRef#4866)
2b4f831 Fixed page-range-format (JabRef#4863)
d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (JabRef#4860)
e433c99 fix delimiter issue for bioscience.csl (JabRef#4876)
4d97aab update et-al settings for stroke.csl (JabRef#4875)
342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4868)
91fe25e Add article number to IEEE (JabRef#4867)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a995c63
github-actions bot pushed a commit to dimitra-karadima/jabref that referenced this pull request Jul 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63
e4e13cd 
a995c63 Create errata.csl (JabRef#4894)
883b9cd Update archeologie-medievale.csl (JabRef#4892)
a942b5c Update rmit-university-harvard.csl (JabRef#4890)
5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4891)
f2a8fe3 Fix AVMA style
c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4872)
9f106eb Update rmit-university-harvard.csl (JabRef#4884)
5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (JabRef#4886)
7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (JabRef#4871)
ae5eba3 Create revue-archeologique-de-lest.csl (JabRef#4881)
58a1672 Create pacific-conservation-biology.csl (JabRef#4880)
381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (JabRef#4879)
c66a5c0 Create society-of-biblical-literature-author-date.csl (JabRef#4812)
008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (JabRef#4874)
193385a Update manchester (JabRef#4878)
fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (JabRef#4856)
2f70b14 Add "personal communication" to remaining APA locales (JabRef#4866)
2b4f831 Fixed page-range-format (JabRef#4863)
d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (JabRef#4860)
e433c99 fix delimiter issue for bioscience.csl (JabRef#4876)
4d97aab update et-al settings for stroke.csl (JabRef#4875)
342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4868)
91fe25e Add article number to IEEE (JabRef#4867)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a995c63
github-actions bot pushed a commit to Xuanxuan-Zou/jabref that referenced this pull request Jul 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63
3c3d851 
a995c63 Create errata.csl (JabRef#4894)
883b9cd Update archeologie-medievale.csl (JabRef#4892)
a942b5c Update rmit-university-harvard.csl (JabRef#4890)
5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4891)
f2a8fe3 Fix AVMA style
c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4872)
9f106eb Update rmit-university-harvard.csl (JabRef#4884)
5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (JabRef#4886)
7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (JabRef#4871)
ae5eba3 Create revue-archeologique-de-lest.csl (JabRef#4881)
58a1672 Create pacific-conservation-biology.csl (JabRef#4880)
381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (JabRef#4879)
c66a5c0 Create society-of-biblical-literature-author-date.csl (JabRef#4812)
008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (JabRef#4874)
193385a Update manchester (JabRef#4878)
fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (JabRef#4856)
2f70b14 Add "personal communication" to remaining APA locales (JabRef#4866)
2b4f831 Fixed page-range-format (JabRef#4863)
d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (JabRef#4860)
e433c99 fix delimiter issue for bioscience.csl (JabRef#4876)
4d97aab update et-al settings for stroke.csl (JabRef#4875)
342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4868)
91fe25e Add article number to IEEE (JabRef#4867)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a995c63
github-actions bot pushed a commit to calixtus/jabref that referenced this pull request Jul 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63
8887205 
a995c63 Create errata.csl (JabRef#4894)
883b9cd Update archeologie-medievale.csl (JabRef#4892)
a942b5c Update rmit-university-harvard.csl (JabRef#4890)
5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4891)
f2a8fe3 Fix AVMA style
c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4872)
9f106eb Update rmit-university-harvard.csl (JabRef#4884)
5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (JabRef#4886)
7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (JabRef#4871)
ae5eba3 Create revue-archeologique-de-lest.csl (JabRef#4881)
58a1672 Create pacific-conservation-biology.csl (JabRef#4880)
381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (JabRef#4879)
c66a5c0 Create society-of-biblical-literature-author-date.csl (JabRef#4812)
008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (JabRef#4874)
193385a Update manchester (JabRef#4878)
fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (JabRef#4856)
2f70b14 Add "personal communication" to remaining APA locales (JabRef#4866)
2b4f831 Fixed page-range-format (JabRef#4863)
d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (JabRef#4860)
e433c99 fix delimiter issue for bioscience.csl (JabRef#4876)
4d97aab update et-al settings for stroke.csl (JabRef#4875)
342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4868)
91fe25e Add article number to IEEE (JabRef#4867)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a995c63
github-actions bot pushed a commit to ShikunXiong/jabref that referenced this pull request Jul 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63
45ccd23 
a995c63 Create errata.csl (JabRef#4894)
883b9cd Update archeologie-medievale.csl (JabRef#4892)
a942b5c Update rmit-university-harvard.csl (JabRef#4890)
5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4891)
f2a8fe3 Fix AVMA style
c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4872)
9f106eb Update rmit-university-harvard.csl (JabRef#4884)
5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (JabRef#4886)
7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (JabRef#4871)
ae5eba3 Create revue-archeologique-de-lest.csl (JabRef#4881)
58a1672 Create pacific-conservation-biology.csl (JabRef#4880)
381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (JabRef#4879)
c66a5c0 Create society-of-biblical-literature-author-date.csl (JabRef#4812)
008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (JabRef#4874)
193385a Update manchester (JabRef#4878)
fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (JabRef#4856)
2f70b14 Add "personal communication" to remaining APA locales (JabRef#4866)
2b4f831 Fixed page-range-format (JabRef#4863)
d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (JabRef#4860)
e433c99 fix delimiter issue for bioscience.csl (JabRef#4876)
4d97aab update et-al settings for stroke.csl (JabRef#4875)
342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4868)
91fe25e Add article number to IEEE (JabRef#4867)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a995c63
github-actions bot pushed a commit to felixbohnacker/jabref that referenced this pull request Jul 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63
9567afb 
a995c63 Create errata.csl (JabRef#4894)
883b9cd Update archeologie-medievale.csl (JabRef#4892)
a942b5c Update rmit-university-harvard.csl (JabRef#4890)
5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4891)
f2a8fe3 Fix AVMA style
c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4872)
9f106eb Update rmit-university-harvard.csl (JabRef#4884)
5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (JabRef#4886)
7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (JabRef#4871)
ae5eba3 Create revue-archeologique-de-lest.csl (JabRef#4881)
58a1672 Create pacific-conservation-biology.csl (JabRef#4880)
381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (JabRef#4879)
c66a5c0 Create society-of-biblical-literature-author-date.csl (JabRef#4812)
008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (JabRef#4874)
193385a Update manchester (JabRef#4878)
fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (JabRef#4856)
2f70b14 Add "personal communication" to remaining APA locales (JabRef#4866)
2b4f831 Fixed page-range-format (JabRef#4863)
d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (JabRef#4860)
e433c99 fix delimiter issue for bioscience.csl (JabRef#4876)
4d97aab update et-al settings for stroke.csl (JabRef#4875)
342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4868)
91fe25e Add article number to IEEE (JabRef#4867)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a995c63
github-actions bot pushed a commit to eetian/jabref that referenced this pull request Jul 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63
b025b21 
a995c63 Create errata.csl (JabRef#4894)
883b9cd Update archeologie-medievale.csl (JabRef#4892)
a942b5c Update rmit-university-harvard.csl (JabRef#4890)
5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4891)
f2a8fe3 Fix AVMA style
c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4872)
9f106eb Update rmit-university-harvard.csl (JabRef#4884)
5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (JabRef#4886)
7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (JabRef#4871)
ae5eba3 Create revue-archeologique-de-lest.csl (JabRef#4881)
58a1672 Create pacific-conservation-biology.csl (JabRef#4880)
381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (JabRef#4879)
c66a5c0 Create society-of-biblical-literature-author-date.csl (JabRef#4812)
008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (JabRef#4874)
193385a Update manchester (JabRef#4878)
fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (JabRef#4856)
2f70b14 Add "personal communication" to remaining APA locales (JabRef#4866)
2b4f831 Fixed page-range-format (JabRef#4863)
d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (JabRef#4860)
e433c99 fix delimiter issue for bioscience.csl (JabRef#4876)
4d97aab update et-al settings for stroke.csl (JabRef#4875)
342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4868)
91fe25e Add article number to IEEE (JabRef#4867)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a995c63
github-actions bot pushed a commit that referenced this pull request Jul 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63
a3bf87f 
a995c63 Create errata.csl (#4894)
883b9cd Update archeologie-medievale.csl (#4892)
a942b5c Update rmit-university-harvard.csl (#4890)
5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (#4891)
f2a8fe3 Fix AVMA style
c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (#4872)
9f106eb Update rmit-university-harvard.csl (#4884)
5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (#4886)
7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (#4871)
ae5eba3 Create revue-archeologique-de-lest.csl (#4881)
58a1672 Create pacific-conservation-biology.csl (#4880)
381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (#4879)
c66a5c0 Create society-of-biblical-literature-author-date.csl (#4812)
008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (#4874)
193385a Update manchester (#4878)
fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (#4856)
2f70b14 Add "personal communication" to remaining APA locales (#4866)
2b4f831 Fixed page-range-format (#4863)
d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (#4860)
e433c99 fix delimiter issue for bioscience.csl (#4876)
4d97aab update et-al settings for stroke.csl (#4875)
342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (#4868)
91fe25e Add article number to IEEE (#4867)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a995c63
github-actions bot pushed a commit to systemoperator/jabref that referenced this pull request Jul 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63
98641d4 
a995c63 Create errata.csl (JabRef#4894)
883b9cd Update archeologie-medievale.csl (JabRef#4892)
a942b5c Update rmit-university-harvard.csl (JabRef#4890)
5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4891)
f2a8fe3 Fix AVMA style
c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4872)
9f106eb Update rmit-university-harvard.csl (JabRef#4884)
5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (JabRef#4886)
7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (JabRef#4871)
ae5eba3 Create revue-archeologique-de-lest.csl (JabRef#4881)
58a1672 Create pacific-conservation-biology.csl (JabRef#4880)
381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (JabRef#4879)
c66a5c0 Create society-of-biblical-literature-author-date.csl (JabRef#4812)
008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (JabRef#4874)
193385a Update manchester (JabRef#4878)
fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (JabRef#4856)
2f70b14 Add "personal communication" to remaining APA locales (JabRef#4866)
2b4f831 Fixed page-range-format (JabRef#4863)
d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (JabRef#4860)
e433c99 fix delimiter issue for bioscience.csl (JabRef#4876)
4d97aab update et-al settings for stroke.csl (JabRef#4875)
342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4868)
91fe25e Add article number to IEEE (JabRef#4867)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a995c63
github-actions bot pushed a commit to leitianjian/jabref that referenced this pull request Jul 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63
6560892 
a995c63 Create errata.csl (JabRef#4894)
883b9cd Update archeologie-medievale.csl (JabRef#4892)
a942b5c Update rmit-university-harvard.csl (JabRef#4890)
5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4891)
f2a8fe3 Fix AVMA style
c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4872)
9f106eb Update rmit-university-harvard.csl (JabRef#4884)
5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (JabRef#4886)
7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (JabRef#4871)
ae5eba3 Create revue-archeologique-de-lest.csl (JabRef#4881)
58a1672 Create pacific-conservation-biology.csl (JabRef#4880)
381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (JabRef#4879)
c66a5c0 Create society-of-biblical-literature-author-date.csl (JabRef#4812)
008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (JabRef#4874)
193385a Update manchester (JabRef#4878)
fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (JabRef#4856)
2f70b14 Add "personal communication" to remaining APA locales (JabRef#4866)
2b4f831 Fixed page-range-format (JabRef#4863)
d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (JabRef#4860)
e433c99 fix delimiter issue for bioscience.csl (JabRef#4876)
4d97aab update et-al settings for stroke.csl (JabRef#4875)
342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4868)
91fe25e Add article number to IEEE (JabRef#4867)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a995c63
github-actions bot pushed a commit to dextep/jabref that referenced this pull request Jul 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63
45041b4 
a995c63 Create errata.csl (JabRef#4894)
883b9cd Update archeologie-medievale.csl (JabRef#4892)
a942b5c Update rmit-university-harvard.csl (JabRef#4890)
5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4891)
f2a8fe3 Fix AVMA style
c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4872)
9f106eb Update rmit-university-harvard.csl (JabRef#4884)
5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (JabRef#4886)
7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (JabRef#4871)
ae5eba3 Create revue-archeologique-de-lest.csl (JabRef#4881)
58a1672 Create pacific-conservation-biology.csl (JabRef#4880)
381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (JabRef#4879)
c66a5c0 Create society-of-biblical-literature-author-date.csl (JabRef#4812)
008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (JabRef#4874)
193385a Update manchester (JabRef#4878)
fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (JabRef#4856)
2f70b14 Add "personal communication" to remaining APA locales (JabRef#4866)
2b4f831 Fixed page-range-format (JabRef#4863)
d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (JabRef#4860)
e433c99 fix delimiter issue for bioscience.csl (JabRef#4876)
4d97aab update et-al settings for stroke.csl (JabRef#4875)
342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4868)
91fe25e Add article number to IEEE (JabRef#4867)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a995c63
github-actions bot pushed a commit to joe9111/jabref that referenced this pull request Jul 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63
96a235c 
a995c63 Create errata.csl (JabRef#4894)
883b9cd Update archeologie-medievale.csl (JabRef#4892)
a942b5c Update rmit-university-harvard.csl (JabRef#4890)
5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4891)
f2a8fe3 Fix AVMA style
c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4872)
9f106eb Update rmit-university-harvard.csl (JabRef#4884)
5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (JabRef#4886)
7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (JabRef#4871)
ae5eba3 Create revue-archeologique-de-lest.csl (JabRef#4881)
58a1672 Create pacific-conservation-biology.csl (JabRef#4880)
381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (JabRef#4879)
c66a5c0 Create society-of-biblical-literature-author-date.csl (JabRef#4812)
008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (JabRef#4874)
193385a Update manchester (JabRef#4878)
fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (JabRef#4856)
2f70b14 Add "personal communication" to remaining APA locales (JabRef#4866)
2b4f831 Fixed page-range-format (JabRef#4863)
d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (JabRef#4860)
e433c99 fix delimiter issue for bioscience.csl (JabRef#4876)
4d97aab update et-al settings for stroke.csl (JabRef#4875)
342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4868)
91fe25e Add article number to IEEE (JabRef#4867)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a995c63
github-actions bot pushed a commit to graffaner/jabref that referenced this pull request Jul 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63
c0ea3cb 
a995c63 Create errata.csl (JabRef#4894)
883b9cd Update archeologie-medievale.csl (JabRef#4892)
a942b5c Update rmit-university-harvard.csl (JabRef#4890)
5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4891)
f2a8fe3 Fix AVMA style
c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4872)
9f106eb Update rmit-university-harvard.csl (JabRef#4884)
5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (JabRef#4886)
7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (JabRef#4871)
ae5eba3 Create revue-archeologique-de-lest.csl (JabRef#4881)
58a1672 Create pacific-conservation-biology.csl (JabRef#4880)
381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (JabRef#4879)
c66a5c0 Create society-of-biblical-literature-author-date.csl (JabRef#4812)
008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (JabRef#4874)
193385a Update manchester (JabRef#4878)
fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (JabRef#4856)
2f70b14 Add "personal communication" to remaining APA locales (JabRef#4866)
2b4f831 Fixed page-range-format (JabRef#4863)
d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (JabRef#4860)
e433c99 fix delimiter issue for bioscience.csl (JabRef#4876)
4d97aab update et-al settings for stroke.csl (JabRef#4875)
342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4868)
91fe25e Add article number to IEEE (JabRef#4867)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a995c63
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this pull request Jul 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63
2e99b5d 
a995c63 Create errata.csl (JabRef#4894)
883b9cd Update archeologie-medievale.csl (JabRef#4892)
a942b5c Update rmit-university-harvard.csl (JabRef#4890)
5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4891)
f2a8fe3 Fix AVMA style
c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (JabRef#4872)
9f106eb Update rmit-university-harvard.csl (JabRef#4884)
5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (JabRef#4886)
7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (JabRef#4871)
ae5eba3 Create revue-archeologique-de-lest.csl (JabRef#4881)
58a1672 Create pacific-conservation-biology.csl (JabRef#4880)
381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (JabRef#4879)
c66a5c0 Create society-of-biblical-literature-author-date.csl (JabRef#4812)
008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (JabRef#4874)
193385a Update manchester (JabRef#4878)
fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (JabRef#4856)
2f70b14 Add "personal communication" to remaining APA locales (JabRef#4866)
2b4f831 Fixed page-range-format (JabRef#4863)
d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (JabRef#4860)
e433c99 fix delimiter issue for bioscience.csl (JabRef#4876)
4d97aab update et-al settings for stroke.csl (JabRef#4875)
342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4868)
91fe25e Add article number to IEEE (JabRef#4867)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a995c63
Siedlerchr pushed a commit that referenced this pull request Aug 22, 2020
@calixtus
Streamline new library command (#6773)
dc55a76 
* Squashed 'src/main/resources/csl-styles/' changes from 586e0b8..c5f14e2

c5f14e2 Update journal-of-plant-ecology.csl (#4837)
b5d00ab Hotfix: pravnik.csl & iso690-full-note-cs.csl (#4833)
fb8d48a add PMID and DOI (#4832)
7ebdfff Update lancaster-university-harvard.csl (#4836)
8771e21 Create journal-of-clinical-neurology.csl (#4835)
70beb7b Harvard Lancaster: Fix in-text locator
0709b73 Update informal-logic.csl (#4831)
d18d133 Update gost-r-7-0-5-2008.csl (#4829)
cfb5389 Update gost-r-7-0-5-2008-numeric.csl (#4828)
0fc46ea Update gost-r-7-0-5-2008-numeric-alphabetical.csl (#4827)
fac26cb Create feminist-theory.csl (#4830)
a2721e6 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl, and iso690-full-note-cs.csl (#4826)
2f0d735 Improve localization of DGfP
683d7d1 Create zeitschrift-fur-theologie-und-philosophie.csl (#4813)
7c82406 always show DOI in aps.csl (#4820)
1eb531d Update journal-of-international-business-studies.csl (#4819)
9caf926 Create interdisziplinare-anthropologie.csl (#4818)
00210e1 UKSW2 (#4807)
015db6e UKSW1 (#4800)
f706ef5 Update masarykova-univerzita-pravnicka-fakulta.csl (#4822)
096108d Update epilepsia.csl (#4823)
07ebdc3 Update eksploatacja-i-niezawodnosc.csl (#4824)
3d50f3c Create ABNT-Universidade-Federal-de-Pernambuco-CFCH.csl (#4798)
df94fa1 Update eksploatacja-i-niezawodnosc.csl (#4808)
4089be5 Update bulletin-de-la-societe-prehistorique-francaise.csl (#4810)
f130aa7 Update molecular-biology-and-evolution.csl (#4814)
86f452f Create heiliger-dienst.csl (#4815)
5ccd3e9 Update revista-brasileira-de-ciencia-do-solo.csl (#4817)
0eea734 Fix a delimiter in journal-of-the-royal-society-of-western-australia.csl (#4811)
1cbe790 Delete heiliger-dienst.csl
19fa29f Create heiliger-dienst.csl (#4787)
888bad1 Update RMIT Harvard to match Easy Cite (#4788)
46011dd Create universite-nangui-abrogoua-ufr-sn (#4676)
174adab Create apa-6th-edition-no-ampersand.csl (#4767)
03cf65f Create journal-of-plant-protection-research.csl (#4797)
c749084 Update eksploatacja-i-niezawodnosc.csl (#4782)
17e1501  Update masarykova-univerzita-pravnicka-fakulta.csl (#4783)
5596d18 Update revista-brasileira-de-ciencia-do-solo.csl (#4790)
9c1a381 create csl for the journal Textual Cultures (#4785)
8345762 Update taylor-and-francis-national-library-of-medicine.csl (#4786)
5ec1acf Create british-journal-of-criminology.csl (#4789)
68550ac Update angewandte-chemie.csl (#4791)
09e2755 Create shock.csl (#4792)
d46e49e Update antioxidants-and-redox-signaling.csl (#4793)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: c5f14e2

* Squashed 'src/main/resources/csl-styles/' changes from c5f14e2..716f635

716f635 Update changes in Harvard-Stellenbosch (#4862)
a6a9a1a Create alkoholizmus-a-drogove-zavislosti.csl (#4859)
0560ca0 Update journal-of-the-american-college-of-surgeons.csl (#4858)
9e16631 create independent style for cellular-and-molecular-gastroenterology-and-hepatology.csl (#4852)
87b0853 Update antiquity.csl (#4841)
cb4e7f7 Update heart-rhythm.csl (#4850)
b3b55ee Create iisue-moderno (#4846)
63973a7 Create etasr.csl (#4848)
9942138 Create style for Journal of Vertebrate Biology (#4849)
7c7f3d3 Add Future Medicine dependents (#4838)
abe2066 Update methods-of-information-in-medicine.csl (#4847)
c64d98b create independent style for new-zealand-journal-of-forestry-science (#4844)
28265f9 Create continuity-and-change.csl (#4839)
d065fdd Create journal-of-clinical-ethics.csl (#4842)
b9fbfa3 Update future-medicine.csl (#4843)
ceb56fa Create future-medicine.csl (#4834)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 716f635

* Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63

a995c63 Create errata.csl (#4894)
883b9cd Update archeologie-medievale.csl (#4892)
a942b5c Update rmit-university-harvard.csl (#4890)
5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (#4891)
f2a8fe3 Fix AVMA style
c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (#4872)
9f106eb Update rmit-university-harvard.csl (#4884)
5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (#4886)
7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (#4871)
ae5eba3 Create revue-archeologique-de-lest.csl (#4881)
58a1672 Create pacific-conservation-biology.csl (#4880)
381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (#4879)
c66a5c0 Create society-of-biblical-literature-author-date.csl (#4812)
008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (#4874)
193385a Update manchester (#4878)
fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (#4856)
2f70b14 Add "personal communication" to remaining APA locales (#4866)
2b4f831 Fixed page-range-format (#4863)
d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (#4860)
e433c99 fix delimiter issue for bioscience.csl (#4876)
4d97aab update et-al settings for stroke.csl (#4875)
342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (#4868)
91fe25e Add article number to IEEE (#4867)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a995c63

* Squashed 'src/main/resources/csl-styles/' changes from a995c63..bf698ac

bf698ac Create common-market-law-review.csl (#4910)
c962eca Create harvard-prifysgol-caerdydd.csl (#4922)
0c24e7f Update gewerblicher-rechtsschutz-und-urheberrecht.csl (#4923)
d2ec1a7 Create Tijdschrift-voor-Geneeskunde.csl (#4907)
5df7250 Update harvard-institut-fur-praxisforschung-de.csl (#4918)
093fd91 Update universite-de-montreal-apa.csl (#4916)
a3e41d4 Update thieme-german.csl (#4919)
648765a add DOI to aerosol-science-and-technology.csl (#4909)
bc1ebee Reindent/reorder
a8dc18a Fix documentation link for epidemiology & infection
aab403a Fix AGLC Newspaper date
4c018d5 Add period between editor and translator (SBL styles) (#4906)
42f7491 Create geographische-zeitschrift.csl (#4898)
a4002a6 Create german-kunstwissenschaft.csl (#4896)
b01910b Disambiguation of names (#4895)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: bf698ac

* Squashed 'src/main/resources/csl-styles/' changes from bf698ac..7cab2f7

7cab2f7 Create depro-ufs.csl (#4947)
2fcda1f Create journal-of-sport-science-and-medicine.csl (#4949)
cd457d4 Update american-marketing-association.csl (#4945)
cacc4ee Create nejm-catalyst.csl (#4943)
bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (#4941)
1f706cd Update health-services-research.csl (#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (#4932)
e79640e Create afro-asia.csl (#4934)
c601aa4 Update lancaster-university-harvard.csl (#4938)
184fd90 Update collection-du-centre-jean-berard.csl (#4936)
82f9aec fix et-al & add DOI thyroid.csl (#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (#4905)
3cab27d Update thieme-german.csl (#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (#4925)
4adb1ea Create karstenia.csl (#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 7cab2f7

* Squashed 'src/main/resources/csl-styles/' changes from 7cab2f7..827b986

827b986 add DOI preprint to american-society-for-microbiology.csl (#4946)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 827b986

* Squashed 'src/main/resources/csl-styles/' changes from 827b986..eb0d37e

eb0d37e Create natbib-plainnat-author-dat.csl (#4967)
fb1592a Update journal-of-fish-biology.csl (#4969)
f6876cb Update .travis.yml (#4970)
d6d400b Create london-review-of-international-law.csl (#4966)
d2a5ae1 Update harvard-stellenbosch-university.csl (#4965)
9c62141 Create phytopathologia-mediterranea.csl (#4964)
8ca2ea1 Update historical-materialism.csl (#4960)
80456dc Update historical-materialism.csl
be2d910 Update historical-materialism.csl
1d1cf09 Create atlande.csl (#4930)
89f41d4 Create juristische-zitierweise-oeffentliches-recht.csl (#4944)
8c677a0 Create korean-journal-of-gastroenterology.csl (#4954)
eadb950 Create historical-materialism.csl (#4955)
5553dcd Create revista-materia.csl (#4957)
d23a3ab Bug fix in APA 6 original publication macro (#4959)
66f9974 Always print publisher in APA 6th edition (#4899)
868809c Create agora.csl (#4940)
99c19c3 Update anthropologie-et-societes.csl (#4952)
ee17423 Create critical-reviews-in-solid-state-and-materials-science.csl (#4951)
7a13a7d Create korean-journal-of-internal-medicine.csl (#4953)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: eb0d37e

* Merged new library actions

* l10n

* Removed unused constructor

* Fixed checkstyle failed check

* Fixed one more checkstyle issue

Co-authored-by: github actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez left review comments

@koppor koppor koppor left review comments

@Siedlerchr Siedlerchr Siedlerchr left review comments

Assignees
No one assigned
Labels
build-system status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: code-quality Issues related to code or architecture decisions
Projects
None yet
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@LinusDietz @Siedlerchr @tobiasdiez @koppor