Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display of favorites for ties #158

Closed
JacobEvelyn opened this issue Mar 19, 2017 · 3 comments
Closed

Improve display of favorites for ties #158

JacobEvelyn opened this issue Mar 19, 2017 · 3 comments
Milestone

Comments

@JacobEvelyn
Copy link
Owner

JacobEvelyn commented Mar 19, 2017

Currently, we display favorites like so:

1. Marie Curie              (3 activities)
2. George Washington Carver (3)
3. Elizabeth Cady Stanton   (3)
4. Someone Else             (2)

When in reality the top three friends are all tied for first place, so they should be displayed either like this:

1. Marie Curie              (3 activities)
1. George Washington Carver (3)
1. Elizabeth Cady Stanton   (3)
4. Someone Else             (2)

or possibly like this:

*1. Marie Curie              (3 activities)
*1. George Washington Carver (3)
*1. Elizabeth Cady Stanton   (3)
 4. Someone Else             (2)
@JacobEvelyn JacobEvelyn added this to the 1.0 milestone Mar 19, 2017
@JacobEvelyn
Copy link
Owner Author

@JacobEvelyn
Copy link
Owner Author

I think my leaning is for simplicity's sake to not have asterisks or any special indication for the tied numbers.

@JacobEvelyn
Copy link
Owner Author

This is released in v0.30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant