Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve display of favorites for ties #165

Merged
merged 1 commit into from
May 29, 2017
Merged

Improve display of favorites for ties #165

merged 1 commit into from
May 29, 2017

Conversation

JacobEvelyn
Copy link
Owner

@JacobEvelyn JacobEvelyn commented May 29, 2017 •
edited
Loading

Fixes #158.

Hi there! Thanks so much for submitting a pull request!

Let's just make sure together that all of these boxes are checked before we
merge this change:

  • The code in these changes works correctly.
  • Code has tests as appropriate.
  • Code has been reviewed by @JacobEvelyn.
  • All tests pass on TravisCI.
  • Rubocop reports no issues on TravisCI.
  • The README.md file is updated as appropriate.

Don't worry—this list will get checked off in no time!

@JacobEvelyn JacobEvelyn force-pushed the rank-and-file branch 2 times, most recently from 37dd436 to d07d0bc Compare May 29, 2017 17:41
@coveralls
Copy link

coveralls commented May 29, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 97.188% when pulling 0ff14b6 on rank-and-file into 8910b84 on master.

@JacobEvelyn JacobEvelyn merged commit 309bd1c into master May 29, 2017
@JacobEvelyn JacobEvelyn deleted the rank-and-file branch May 29, 2017 19:33
@JacobEvelyn
Copy link
Owner Author

This is released in v0.30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JacobEvelyn @coveralls