Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin RuboCop version for Travis tests #234

Merged
merged 1 commit into from
May 16, 2019
Merged

Pin RuboCop version for Travis tests #234

merged 1 commit into from
May 16, 2019

Conversation

JacobEvelyn
Copy link
Owner

@JacobEvelyn JacobEvelyn commented May 16, 2019


Hi there! Thanks so much for submitting a pull request!

Let's just make sure together that all of these boxes are checked before we
merge this change:

  • The code in these changes works correctly.
  • Code has tests as appropriate.
  • Code has been reviewed by @JacobEvelyn.
  • All tests pass on Travis CI.
  • Code coverage remains high.
  • Rubocop reports no issues on Travis CI.
  • The README.md file is updated as appropriate.

Don't worry—this list will get checked off in no time!

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #234 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #234   +/-   ##
======================================
  Coverage    98.3%   98.3%           
======================================
  Files          23      23           
  Lines         709     709           
======================================
  Hits          697     697           
  Misses         12      12
Impacted Files Coverage Δ
lib/friends/introvert.rb 98.58% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38e3e82...820ebb2. Read the comment docs.

@JacobEvelyn JacobEvelyn changed the title Fix setup for Rubocop 0.69+ Pin RuboCop version for Travis tests May 16, 2019
@JacobEvelyn JacobEvelyn merged commit f0a44f4 into master May 16, 2019
@JacobEvelyn JacobEvelyn deleted the fix-rubocop branch May 16, 2019 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant