Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin RuboCop version for Travis tests #234

Merged
merged 1 commit into from
May 16, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ matrix:
- rvm: 2.6
script:
- bundle exec rake test
- gem install --no-document rubocop && rubocop
- gem install --no-document rubocop -v 0.67 && rubocop
env:
- CODE_COVERAGE=true
branches:
Expand Down
2 changes: 1 addition & 1 deletion friends.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
spec.email = ["[email protected]"]
spec.summary = "Spend time with the people you care about."
spec.description = "Spend time with the people you care about. "\
"Introvert-tested. Extrovert-approved."
"Introvert-tested. Extrovert-approved."
spec.homepage = "https://github.com/JacobEvelyn/friends"
spec.license = "MIT"
spec.post_install_message = Friends::POST_INSTALL_MESSAGE
Expand Down
4 changes: 2 additions & 2 deletions lib/friends/introvert.rb
Original file line number Diff line number Diff line change
Expand Up @@ -710,8 +710,8 @@ def parse_line!(line, line_num:, state:)

begin
instance_variable_get("@#{stage.id}") << stage.klass.deserialize(line)
rescue => e # rubocop:disable Style/RescueStandardError
bad_line(e, line_num)
rescue => ex # rubocop:disable Style/RescueStandardError
bad_line(ex, line_num)
end

state
Expand Down