Custom Editor API

[ManuelHentschel]

Implements the changes discussed in #3951

I added a new viewmode instead of replacing the "singleton" mode, in case some users want to preserve the specific behavior of that mode, but of course that can be changed easily.

I had to add the option "latex-workshop.view.pdf.tab.viewColumn", since the current option "latex-workshop.view.pdf.tab.editorGroup" is not compatible with the editor-open API of vscode, and merging the two felt rather confusing.

[James-Yu]

Can you take a look at 8c3df83 and see if things work as you intended?

[ManuelHentschel]

Can you take a look at 8c3df83 and see if things work as you intended?

With this change, the command latex-workshop.tab opens the (non-custom-editor) viewer, even if otherwise the custom editor API is specified in the settings. In line with your earlier comment, I think it would make sense to adjust the behavior of this command to choose the correct internal viewer. This is why I used the 'internal' option in some places. To avoid that we can also put more logic into main.ts if you prefer that over using "internal".

Also, omitting the default value in Viewer.open also causes the command latex-workshop.view to stop working.

[James-Yu]

I suppose f8c7c3a fixes both?

[ManuelHentschel]

I suppose f8c7c3a fixes both?

The latest version seems to work as intended

[James-Yu]

Before merge, please add related tests. A minimum one is to try setting the config and view and see if a viewer is fired. You may refer to other tests for the implementation. I do encourage to add more as you may think of (I am not quite sufficient in thinking of different test cases.)

[James-Yu]

Thanks for your contribution!

[James-Yu]

It seems that the custom editors can be duplicated by the "splitting" button, which I think is acceptable. Therefore, I'd propose to switch the options of view.mode to

• tab uses custom editor
• singleton uses old logic (primary unchanged), marked with "deprecated"
• Remove customEditor
• Add legacy, which uses old logic

What do you think? @ManuelHentschel

[ManuelHentschel]

It seems that the custom editors can be duplicated by the "splitting" button, which I think is acceptable. Therefore, I'd propose to switch the options of view.mode to

* `tab` uses custom editor

* `singleton` uses old logic (primary unchanged), marked with "deprecated"

* Remove `customEditor`

* Add `legacy`, which uses old logic

What do you think? @ManuelHentschel

Sounds good to me!