Bump guice-servlet from 5.1.0 to 7.0.0 #3836
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps guice-servlet from 5.1.0 to 7.0.0. --- updated-dependencies: - dependency-name: com.google.inject.extensions:guice-servlet dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
backport/v0.6
dependencies
|
The release for Guice 7.0.0 mention a breaking change related to the |
There was a problem hiding this comment.
Looks like I was wrong about not needing Guice any more. I tried to remove it, but that lets a test consistently fail: ConfigurationManagementGraphServerTest.bindingShouldExistAfterGraphIsCreated
However, I read the release notes for Guice 7.0.0 more carefully and they only mention 3 specific namespaces that don't work any more with Guice 7: javax.inject, javax.servlet, and javax.persistence. Out of these 3, I only found javax.servlet as a dependency, but I couldn't find any usage as an import.
So, I guess the update is unproblematic for us.
I haven't checked how this dependency is related, but I see |
There was a problem hiding this comment.
I haven't checked how this dependency is related, but I see bindingShouldExistAfterGraphIsCreated is often fail currently. I have to restart it often in GitHub Actions. I haven't checked the test itself but I assume it's a flaky test.
I think you're right. I also noticed it failing more often for completely different branches. I'm not even sure if this test is flaky or whether it's completely broken at the moment as it seems to fail consistently, even with restarted jobs.
However, locally it passed for me.
I created an issue for this: #3849
This probably also means that we can in fact remove guice. So, we don't need to merge this PR.
|
PR to remove Guice: #3852 @dependabot ignore this dependency |
|
OK, I won't notify you about com.google.inject.extensions:guice-servlet again, unless you re-open this PR. 😢 |
dependabot
bot
deleted the
dependabot/maven/com.google.inject.extensions-guice-servlet-7.0.0
branch
Bumps guice-servlet from 5.1.0 to 7.0.0.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)